Speed up canonical ref redirects#117
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Improves public CDN routing so requests that include non-canonical refs (branches/tags/short SHAs) are resolved and redirected to a canonical full-commit SHA URL early, avoiding unnecessary downstream file/build work and (optionally) avoiding esbuild detection during redirects.
Changes:
- Add early 302 redirect flow in the public router when an explicit ref resolves to a different canonical commit SHA, with
no-storecaching. - Thread a
detectEsbuildflag through the resolver call chain so redirects can skip esbuild detection work. - Extend router + downloader tests to cover canonical ref redirects, SHA direct serving, and strict
detectEsbuildhandling.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
app/router.js |
Adds canonical-ref redirect path, ref explicitness helper, and conditional esbuild-detection skipping for redirects. |
app/downloader-service.js |
Skips branch/commit metadata lookup for full SHAs and allows disabling esbuild detection via context. |
downloader-server.js |
Passes detectEsbuild through /v1/resolve with a strict boolean check. |
test/router.js |
Adds/updates cases for canonical redirects vs direct canonical SHA serving and validates detectEsbuild behavior. |
test/downloader-service.js |
Adds coverage for strict detectEsbuild propagation and SHA resolver behavior. |
Comment on lines
+145
to
+150
| if (url !== req.url) { | ||
| startTrace(commit) | ||
| setPublicHeaders(res, 302, rate) | ||
| res.set({ 'Cache-Control': 'no-store', 'CDN-Cache-Control': 'no-store' }) | ||
| if (rate.limit !== undefined) res.set('X-GitHub-RateLimit-Limit', String(rate.limit)) | ||
| return res.redirect(302, url) |
goransle
marked this pull request as ready for review
July 23, 2026 09:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.