fix: Restore green EditMode suite for schema and startup-hook guards

[hatayama]

Summary

• EditMode guard failures around first-party schema metadata and editor startup ownership are fixed, so the full EditMode suite returns FailedCount: 0 again.

User Impact

• Before: the EditMode suite failed on schema DescriptionAttribute checks and on forbidden [InitializeOnLoad] ownership outside the composition-root bootstrap.
• After: those guard rules pass again. Domain-load age diagnostics for pause-point still record domain birth (not first access).

Changes

• Remove forbidden DescriptionAttribute usage from SetGameViewSizeSchema (descriptions already live in the skill file and CLI tool JSON).
• Move pause-point domain-load timestamp recording into the composition-root startup chain via PausePointEditorStartup.MarkDomainLoaded.
• Group A (CliSetupApplicationServiceTests pinned dispatcher tag expectations) was already fixed upstream by feat: Show live progress feedback while installing the CLI #1959 (pin-derived expected values), so it is intentionally out of this PR.

Verification

• dist/darwin-arm64/uloop compile --project-path <PROJECT_ROOT> → Success: true, errors 0, warnings 0
• Filtered runs (serial):
  • CliSetupApplicationServiceTests → FailedCount: 0 (4/4)
  • FirstPartyToolSchemaMetadataTests → FailedCount: 0 (2/2)
  • OnionAssemblyDependencyTests → FailedCount: 0 (83/83)
• Full EditMode run → TestCount: 2356, PassedCount: 2349, FailedCount: 0, SkippedCount: 7

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR wires pause-point domain initialization into first-party editor startup, replaces automatic timestamp initialization with an explicit guarded method, grants editor assembly access to internals, and removes description attributes from set-game-view-size schema properties.

Changes

Pause-point startup initialization

Layer / File(s)	Summary
Explicit pause-point domain tracking Packages/src/Editor/FirstPartyTools/PausePoint/PausePointDomainReloadTracker.cs	Domain load time is recorded through MarkDomainLoaded(), while SecondsSinceLoad() validates initialization and calculates elapsed time from the recorded timestamp.
Startup entry point and assembly access Packages/src/Editor/FirstPartyTools/PausePoint/PausePointEditorStartup.cs, Packages/src/Editor/FirstPartyTools/FirstPartyToolsEditorStartup.cs, Packages/src/Editor/FirstPartyTools/PausePoint/AssemblyInfo.cs	A pause-point startup entry point is added, invoked from first-party editor startup, and granted access to internal members through InternalsVisibleTo.

Set-game-view-size schema metadata

Layer / File(s)	Summary
Remove resolution property descriptions Packages/src/Editor/FirstPartyTools/SetGameViewSize/SetGameViewSizeSchema.cs	The component-model import and description attributes for the nullable resolution properties are removed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant FirstPartyToolsEditorStartup
  participant PausePointEditorStartup
  participant PausePointDomainReloadTracker
  FirstPartyToolsEditorStartup->>PausePointEditorStartup: Initialize()
  PausePointEditorStartup->>PausePointDomainReloadTracker: MarkDomainLoaded()
  PausePointDomainReloadTracker-->>PausePointEditorStartup: Store UTC load timestamp

Loading

Possibly related PRs

• hatayama/unity-cli-loop#1681: Adds pause-point internals access for resolver tests.
• hatayama/unity-cli-loop#1834: Adds related set-game-view-size schema and tool changes.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main fix: restoring the EditMode suite by addressing schema and startup-hook guard failures.
Description check	✅ Passed	The description matches the changeset, describing the schema metadata fix, startup initialization change, and verification results.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/editmode-guard-test-failures

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Packages/src/Editor/FirstPartyTools/FirstPartyToolsEditorStartup.cs`:
- Line 14: Move PausePointEditorStartup.Initialize() to the first statement in
Initialize(), before DomainReloadDisableScopeRecovery,
ExternalSceneChangeTracker, and ControlPlayModeEditorStartup, so the domain
timestamp is recorded at startup.

In
`@Packages/src/Editor/FirstPartyTools/PausePoint/PausePointDomainReloadTracker.cs`:
- Around line 16-20: Update MarkDomainLoaded() to retain the existing
_loadedAtUtc value when it is already set, while preserving the current
Debug.Assert invariant check. Only assign DateTime.UtcNow during the first
domain-load initialization so SecondsSinceLoad() continues using the original
timestamp.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f1c7af98-ba2d-4412-b966-1289ce77a646

📥 Commits

Reviewing files that changed from the base of the PR and between 06ae9f3 and 2fef22d.

⛔ Files ignored due to path filters (1)

• Packages/src/Editor/FirstPartyTools/PausePoint/PausePointEditorStartup.cs.meta is excluded by none and included by none

📒 Files selected for processing (5)

• Packages/src/Editor/FirstPartyTools/FirstPartyToolsEditorStartup.cs
• Packages/src/Editor/FirstPartyTools/PausePoint/AssemblyInfo.cs
• Packages/src/Editor/FirstPartyTools/PausePoint/PausePointDomainReloadTracker.cs
• Packages/src/Editor/FirstPartyTools/PausePoint/PausePointEditorStartup.cs
• Packages/src/Editor/FirstPartyTools/SetGameViewSize/SetGameViewSizeSchema.cs

💤 Files with no reviewable changes (1)

• Packages/src/Editor/FirstPartyTools/SetGameViewSize/SetGameViewSizeSchema.cs

Declined both Minor suggestions as out of scope / conflicting with intentional fail-fast contract. See inline replies.