helper/resource: include step number in import state verification failures - #671
Open
massimomazzariol wants to merge 1 commit into
Open
helper/resource: include step number in import state verification failures#671massimomazzariol wants to merge 1 commit into
massimomazzariol wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #525
Description
When import state verification cannot find the imported resource ID in the prior state, the verification currently calls
t.Fatalfdirectly. This prevents the outer test step runner from adding the step number to the failure message.This change returns the verification error instead, allowing the existing import step error handling to report the failure with its step number.
A regression test was added to verify that the final error includes
Step 2/2, along with a Changie entry for the bug fix.Testing
The import state test package passes with both Go versions used by the repository CI matrix:
GOTOOLCHAIN=go1.25.12 go test ./helper/resource/importstate -count=1GOTOOLCHAIN=go1.26.5 go test ./helper/resource/importstate -count=1Tested with:
go test ./... -count=1also encounters pre-existing Windows-specific failures inconfig,helper/resource, andinternal/teststep. The same failures were reproduced on an unmodifiedupstream/mainworktree.Rollback Plan
Changes to Security Controls
No changes to security controls.