fix: correct .gitignore PNG exception paths for the apps/* layout - #8
Merged
Merged
Conversation
… not the pre-reorg paths The blanket *.png rule exempted packages/client/public and packages/blog/public - paths that predate the apps/* monorepo layout and no longer exist. apps/web/public's icons (sui-logo.png, apple-touch-icon.png, favicon-*.png, icon-*.png) were only in the repo at all because 1f30a56 force-added them; the gitignore itself never recognized them as intentional. Suspected live impact: `railway up` (used by both the GitHub Actions deploy workflow and manual deploys) appears to filter its upload by .gitignore patterns rather than git's tracked-file list, so these force-added PNGs never made it into the build Railway actually deploys - explaining the broken-image icon in the sidebar and touch-icon/favicon this whole time, independent of which commit was live.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The blanket `.png` rule in `.gitignore` only exempted `packages/client/public` and `packages/blog/public` - paths from before the monorepo moved to `apps/`. `apps/web/public`'s icons were only in git at all because commit 1f30a56 force-added them past this stale rule.
Suspected root cause of the broken sidebar logo/favicons in production: `railway up` (used by the GitHub Actions deploy workflow) appears to filter its upload by `.gitignore` patterns rather than git's actual tracked-file list, so these force-added PNGs never made it into what Railway actually builds/deploys - regardless of which commit is live. This should fix it.
Test plan