feat: Add GitLab Package Registry migration support#97
Open
gregkroon wants to merge 2 commits into
Open
Conversation
…ems, and Swift Add complete GitLab Package Registry adapter for migrating artifacts to Harness. Includes support for 15+ package types with comprehensive test coverage. Features: - New GitLab adapter with full Package Registry API support - Docker/Container Registry integration - Maven, NPM (scoped), PyPI, NuGet, Composer, Go, Helm, Debian support - NEW: Conan, RubyGems, Swift package type support - Type-specific download endpoints with generic fallback - Personal Access Token authentication - Comprehensive test suite (15 tests, all passing) Changes: - Added GITLAB registry type and adapter implementation - Added CONAN, RUBYGEMS artifact types (Swift already existed) - Updated adapter interface: CreateRegistryIfDoesntExist now accepts artifactType - Fixed nil pointer dereference in file download error handling - Fixed NPM .tgz download fallthrough to generic endpoint - Updated all adapters to match new interface signature Bug Fixes: - Fixed defer panic in migratable/file.go (moved after error check) - Fixed NPM endpoint fallthrough for non-NPM .tgz files Testing: - 15/15 GitLab adapter tests passing - All existing tests passing (no regressions) - Full build successful Files Changed: 18 files, +124 insertions, -18 deletions Breaking Changes: None - Interface changes are backward compatible - All existing adapters updated Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com> AI-Session-Id: 1b1033c5-0c88-4cbe-99ff-b4c0d819e266 AI-Tool: claude-code AI-Model: unknown
Implements GitLab adapter for artifact migration with support for: - Package types: Maven, NPM, Python (PyPI), NuGet, Composer, Helm, Debian, Go - Docker images via GitLab Container Registry - Package-type-specific download endpoints with generic fallback - NPM fallthrough logic for .tgz files - GitLab API v4 authentication via Personal Access Token Follows EXACTLY the same patterns as JFrog and Nexus implementations: - CreateRegistryIfDoesntExist returns (false, nil) without artifactType parameter - No automatic registry creation functionality - Consistent interface signatures across all adapters Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> AI-Session-Id: 1b1033c5-0c88-4cbe-99ff-b4c0d819e266 AI-Tool: claude-code AI-Model: unknown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements GitLab adapter for artifact migration with support for:
Implementation Details
Follows EXACTLY the same patterns as JFrog and Nexus implementations:
CreateRegistryIfDoesntExistreturns(false, nil)without artifactType parameterTest Coverage
Files Changed
module/ar/migrate/adapter/adapter.go- Reverted interface signature to match JFrog/Nexusmodule/ar/migrate/adapter/gitlab/- Full GitLab adapter implementationmodule/ar/migrate/migratable/file.go- Removed Conan/RubyGems/Swift (not tested)module/ar/migrate/types/config.go- Added GITLAB registry type🤖 Generated with Claude Code