fix(profiles): refresh MiniMax model id - #255
Conversation
WalkthroughMiniMax global and China profiles now use ChangesMiniMax model alignment
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR refreshes the shipped global and China MiniMax profiles to use the current
Confidence Score: 5/5The PR appears safe to merge, with the runtime defaults, documentation, and focused expectations remaining synchronized. The changed identifier is applied consistently to both shipped MiniMax profiles and their aliases, while the intended compaction window and M2.7 secondary-tier mapping remain unchanged.
|
| Filename | Overview |
|---|---|
| packages/protocol/src/providers/claude/builtInBackendProfiles.ts | Updates both reachable MiniMax profile defaults consistently without changing their compaction, timeout, endpoint, or secondary-tier settings. |
| apps/ui/sources/sync/domains/profiles/profileDocumentation.ts | Aligns global and China profile descriptions, expected values, and shell examples with the refreshed model identifier. |
| apps/cli/src/settings/profiles/buildProfileEnvOverlay.test.ts | Updates focused assertions that exercise both regional profiles and all affected model aliases. |
Reviews (1): Last reviewed commit: "fix(profiles): refresh MiniMax model id" | Re-trigger Greptile
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/ui/sources/sync/domains/profiles/profileDocumentation.ts`:
- Around line 177-194: Localize the user-visible profile documentation
descriptions and model-selection comments in the profile documentation
definitions, including the additional affected sections. Replace hard-coded
English prose with t(...) calls while keeping environment variable names, model
IDs, and shell syntax literal or interpolated, and add matching translation keys
to every locale under sources/text/translations/.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 95d48c66-32e4-4cdd-b204-266f0ce6395d
📒 Files selected for processing (3)
apps/cli/src/settings/profiles/buildProfileEnvOverlay.test.tsapps/ui/sources/sync/domains/profiles/profileDocumentation.tspackages/protocol/src/providers/claude/builtInBackendProfiles.ts
| description: 'Context capacity used for auto-compaction. Matches M3\'s 1M context window.', | ||
| isSecret: false, | ||
| }, | ||
| { | ||
| name: 'MINIMAX_MODEL', | ||
| expectedValue: 'MiniMax-M3[1m]', | ||
| description: 'Default model. The [1m] suffix selects M3\'s 1M-context variant, as MiniMax\'s Claude Code guide specifies.', | ||
| expectedValue: 'MiniMax-M3', | ||
| description: 'Default model with a 1M-token context window.', | ||
| isSecret: false, | ||
| }, | ||
| { | ||
| name: 'MINIMAX_OPUS_MODEL', | ||
| expectedValue: 'MiniMax-M3[1m]', | ||
| expectedValue: 'MiniMax-M3', | ||
| description: 'Model used when the session selects the Opus tier', | ||
| isSecret: false, | ||
| }, | ||
| { | ||
| name: 'MINIMAX_SONNET_MODEL', | ||
| expectedValue: 'MiniMax-M3[1m]', | ||
| expectedValue: 'MiniMax-M3', |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟠 Major | 🏗️ Heavy lift
Localize the changed profile documentation prose.
The changed description fields and model-selection comments are user-visible documentation, but they remain hard-coded English literals. Resolve the prose through t(...) and add keys to every locale. Keep environment variable names, model IDs, and shell syntax as literal or interpolated values.
As per coding guidelines, “All user-visible strings, accessibility labels, and placeholders must use t(...) and be added to every locale under sources/text/translations/.”
Also applies to: 216-224, 252-269, 291-293
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@apps/ui/sources/sync/domains/profiles/profileDocumentation.ts` around lines
177 - 194, Localize the user-visible profile documentation descriptions and
model-selection comments in the profile documentation definitions, including the
additional affected sections. Replace hard-coded English prose with t(...) calls
while keeping environment variable names, model IDs, and shell syntax literal or
interpolated, and add matching translation keys to every locale under
sources/text/translations/.
Source: Coding guidelines
1 participant
Reason: The shipped global and China MiniMax profiles use a suffixed model identifier instead of the current M3 identifier.
MiniMax-M3for the default, Opus, and Sonnet mappings in both profiles.Checks:
node --experimental-strip-types --check packages/protocol/src/providers/claude/builtInBackendProfiles.tsnode --experimental-strip-types --check apps/ui/sources/sync/domains/profiles/profileDocumentation.tsnode --experimental-strip-types --check apps/cli/src/settings/profiles/buildProfileEnvOverlay.test.tsMiniMax-M3,MiniMax-M2.7, and removal of the suffixed profile identifiergit diff --checkNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by CodeRabbit
MiniMax-M3identifier.Note
Update MiniMax model IDs to remove
[1m]suffix from built-in profilesChanges the default model identifiers for MiniMax and MiniMax CN built-in profiles from
MiniMax-M3[1m]toMiniMax-M3across profile definitions, documentation, and tests. The 1M token context window is retained; only the model ID string is updated to match MiniMax's current API naming.Macroscope summarized 1830ee8.