CMake policy and rules upgrade#8
Open
dfateyev wants to merge 2 commits into
Open
Conversation
CMake 4.0 dropped compatibility with policies older than 3.5, so cmake_minimum_required(VERSION 2.6) no longer configures (FTBFS). Raise the floor to 3.5 and use the range syntax to opt into modern policy behavior without breaking older CMake.
Fedora is dropping the non-standard LIB_SUFFIX / LIB_INSTALL_DIR
variables from its %cmake macro (Changes/CMake_drop_install_vars),
which broke the install rules that hardcoded lib${LIB_SUFFIX}.
This change also should be useful for all modern Linux envs.
Include GNUInstallDirs and install to the standard
CMAKE_INSTALL_LIBDIR / CMAKE_INSTALL_INCLUDEDIR instead, so
the correct multilib path (e.g. lib64) is picked up automatically.
Drop the now unused LIB_INSTALL_DIR block and update
the pkg-config template to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modern environments should benefit from these changes.
Note, I didn't test these changes under BSD (only Linux), but see no evident regressions for it.
This PR addresses issue #7.