XY-1155: Implement source-backed memory quality benchmark#349
Merged
Conversation
…y quality benchmark harness","authority":"XY-1155"}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the XY-1155 executable source-backed memory quality benchmark gate for ELF's final source-backed project memory program.
Changes:
source_backed_qualityJSON report surface and Markdown renderingvalidate-source-backed-qualityso the benchmark command fails on non-pass source-backed quality gatescargo make source-backed-memory-qualityJSON -> validate -> Markdown workflowprivate_scope_leakas a scope violation for the source-backed quality gateDecodex/manual intervention
Decodex was attempted first for XY-1155. Manual intervention was required after repeated Decodex app-server timeouts/no-effective-diff loops, including
Timed out while waiting for app-server outputatapps/decodex/src/agent/json_rpc/connection.rs:287and retained attention after attempts 2/3. This PR is the manual completion path and should be rebound into Decodex review handoff.Benchmark evidence
cargo make source-backed-memory-qualitynow runs:validate-source-backed-qualityLatest local artifact:
tmp/source-backed-memory-quality/report.json:source_backed_quality.result_state = passhard_fail_passed = true1.00.4140.01.01.01.01.00.0001.0/1.0/1.07total,7traced,0incorrectThe aggregate report still preserves typed non-pass competitor/runtime boundaries and does not support an unqualified product-runtime leaderboard claim.
Review
A first read-only skeptic review blocked the change on three P1s: missing executable gate, insufficient hard-fail coverage, and tag-derived Context Pack metrics. The implementation was updated, and a second read-only skeptic review returned
passwith no P0/P1 findings.Validation
cargo make checkscargo make source-backed-memory-qualitypython3 scripts/check-docs.pygit diff --check