Skip to content

Split Dreaming readback artifact helpers #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yvette-carlisle merged 1 commit into from
Jun 30, 2026
Merged

Split Dreaming readback artifact helpers #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
262 changes: 23 additions & 239 deletions apps/elf-eval/src/bin/real_world_live_adapter/dreaming_readback.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
mod dreaming_readback_artifacts;

use crate::{
AGENT_ID, BTreeSet, DreamingReadbackMaterializationEvidence, DreamingReadbackOutput,
ElfService, ListRequest, LoadedJob, OffsetDateTime, Result, Rfc3339, SCOPE, SearchResponse,
AGENT_ID, DreamingReadbackMaterializationEvidence, DreamingReadbackOutput, ElfService,
ListRequest, LoadedJob, OffsetDateTime, Result, Rfc3339, SCOPE, SearchResponse,
SelectedEvidenceText, SuiteMaterializationSelection, SuiteMaterializationSelectionInput,
TENANT_ID, TraceStageOutput, Uuid, eyre, serde_json,
TENANT_ID, Uuid, Value, eyre,
};

pub(super) fn search_response_evidence_ids(response: &SearchResponse) -> Vec<String> {
let mut evidence_ids = Vec::new();

for item in &response.items {
if let Some(evidence_id) =
item.source_ref.get("evidence_id").and_then(serde_json::Value::as_str)
{
if let Some(evidence_id) = item.source_ref.get("evidence_id").and_then(Value::as_str) {
crate::push_unique(&mut evidence_ids, evidence_id.to_string());
}
}
Expand Down Expand Up @@ -85,10 +85,10 @@ pub(super) async fn materialize_elf_dreaming_readback(

let generated_at = OffsetDateTime::now_utc().format(&Rfc3339)?;
let service_evidence_ids = service_readback_evidence_ids(service, project_id).await?;
let mut artifacts = dreaming_readback_template_artifacts(loaded)?;
let mut artifacts = dreaming_readback_artifacts::dreaming_readback_template_artifacts(loaded)?;

for artifact in &mut artifacts {
stamp_dreaming_readback_artifact(
dreaming_readback_artifacts::stamp_dreaming_readback_artifact(
artifact,
loaded,
project_id,
Expand All @@ -100,7 +100,10 @@ pub(super) async fn materialize_elf_dreaming_readback(
let mut artifact_source_refs = Vec::new();

for artifact in &artifacts {
collect_dreaming_artifact_source_refs(artifact, &mut artifact_source_refs);
dreaming_readback_artifacts::collect_dreaming_artifact_source_refs(
artifact,
&mut artifact_source_refs,
);
}

artifact_source_refs.sort();
Expand All @@ -116,8 +119,10 @@ pub(super) async fn materialize_elf_dreaming_readback(
.filter(|source_ref| service_evidence_ids.contains(*source_ref))
.cloned()
.collect::<Vec<_>>();
let scoring_evidence_ids =
dreaming_readback_scoring_evidence_ids(loaded, &service_evidence_ids);
let scoring_evidence_ids = dreaming_readback_artifacts::dreaming_readback_scoring_evidence_ids(
loaded,
&service_evidence_ids,
);
let artifact_kind = match loaded.job.suite.as_str() {
"memory_summary" => "elf.memory_summary/v1",
"proactive_brief" => "elf.proactive_project_brief/v1",
Expand All @@ -136,8 +141,12 @@ pub(super) async fn materialize_elf_dreaming_readback(
source_mutation_count: 0,
no_source_mutation_checked: true,
};
let trace_stages = dreaming_readback_trace_stages(loaded, &materialization);
let content = dreaming_readback_content(loaded.job.suite.as_str(), &artifacts);
let trace_stages =
dreaming_readback_artifacts::dreaming_readback_trace_stages(loaded, &materialization);
let content = dreaming_readback_artifacts::dreaming_readback_content(
loaded.job.suite.as_str(),
&artifacts,
);
let (memory_summaries, proactive_briefs, scheduled_tasks) = match loaded.job.suite.as_str() {
"memory_summary" => (artifacts, Vec::new(), Vec::new()),
"proactive_brief" => (Vec::new(), artifacts, Vec::new()),
Expand All @@ -156,229 +165,6 @@ pub(super) async fn materialize_elf_dreaming_readback(
}))
}

fn dreaming_readback_template_artifacts(loaded: &LoadedJob) -> Result<Vec<serde_json::Value>> {
let pointer = match loaded.job.suite.as_str() {
"memory_summary" => "/corpus/adapter_response/answer/memory_summaries",
"proactive_brief" => "/corpus/adapter_response/answer/proactive_briefs",
"scheduled_memory" => "/corpus/adapter_response/answer/scheduled_tasks",
_ => return Ok(Vec::new()),
};
let artifacts =
loaded.value.pointer(pointer).and_then(serde_json::Value::as_array).cloned().ok_or_else(
|| {
eyre::eyre!(
"{} missing service-native readback template at {pointer}.",
loaded.job.job_id
)
},
)?;

if artifacts.is_empty() {
return Err(eyre::eyre!(
"{} has no service-native readback template artifacts.",
loaded.job.job_id
));
}

Ok(artifacts)
}

fn dreaming_readback_scoring_evidence_ids(
loaded: &LoadedJob,
service_evidence_ids: &[String],
) -> Vec<String> {
let selected = service_evidence_ids.iter().map(String::as_str).collect::<BTreeSet<_>>();
let trap_ids = negative_trap_evidence_ids(loaded);
let mut evidence_ids = Vec::new();

for evidence in &loaded.job.required_evidence {
if selected.contains(evidence.evidence_id.as_str())
&& !trap_ids.contains(evidence.evidence_id.as_str())
{
crate::push_unique(&mut evidence_ids, evidence.evidence_id.clone());
}
}

if evidence_ids.is_empty() {
for evidence_id in service_evidence_ids {
if !trap_ids.contains(evidence_id.as_str()) {
crate::push_unique(&mut evidence_ids, evidence_id.clone());
}
}
}

evidence_ids
}

fn negative_trap_evidence_ids(loaded: &LoadedJob) -> BTreeSet<&str> {
loaded
.value
.get("negative_traps")
.and_then(serde_json::Value::as_array)
.into_iter()
.flatten()
.filter(|trap| {
trap.get("failure_if_used").and_then(serde_json::Value::as_bool).unwrap_or(false)
})
.flat_map(|trap| {
trap.get("evidence_ids")
.and_then(serde_json::Value::as_array)
.into_iter()
.flatten()
.filter_map(serde_json::Value::as_str)
})
.collect()
}

fn stamp_dreaming_readback_artifact(
artifact: &mut serde_json::Value,
loaded: &LoadedJob,
project_id: &str,
trace_id: Uuid,
generated_at: &str,
) {
artifact["generated_at"] = serde_json::json!(generated_at);
artifact["tenant_id"] = serde_json::json!(TENANT_ID);
artifact["project_id"] = serde_json::json!(project_id);
artifact["agent_id"] = serde_json::json!(AGENT_ID);
artifact["read_profile"] = serde_json::json!("private_only");
artifact["service_readback"] = serde_json::json!({
"schema": "elf.service_native_dreaming_readback/v1",
"job_id": loaded.job.job_id,
"suite": loaded.job.suite,
"runtime_path": "ElfService::list",
"search_trace_id": trace_id,
"source_mutation_count": 0
});

if loaded.job.suite == "scheduled_memory" {
let trace = artifact
.as_object_mut()
.map(|object| object.entry("execution_trace").or_insert_with(|| serde_json::json!({})));

if let Some(trace) = trace {
trace["trace_id"] = serde_json::json!(format!("service-native-{trace_id}"));
trace["trigger_kind"] = serde_json::json!("service_native_readback");
trace["status"] = serde_json::json!("completed");
}

artifact["source_mutations"] = serde_json::json!([]);
}
}

fn collect_dreaming_artifact_source_refs(value: &serde_json::Value, refs: &mut Vec<String>) {
match value {
serde_json::Value::Array(items) =>
for item in items {
collect_dreaming_artifact_source_refs(item, refs);
},
serde_json::Value::Object(map) =>
for (key, value) in map {
if matches!(key.as_str(), "source_refs" | "evidence_refs" | "evidence_ids")
&& let Some(items) = value.as_array()
{
for item in items {
if let Some(source_ref) = item.as_str() {
crate::push_unique(refs, source_ref.to_string());
}
}
}
if key == "evidence_id"
&& let Some(source_ref) = value.as_str()
{
crate::push_unique(refs, source_ref.to_string());
}

collect_dreaming_artifact_source_refs(value, refs);
},
_ => {},
}
}

fn dreaming_readback_content(suite: &str, artifacts: &[serde_json::Value]) -> String {
let mut parts = Vec::new();

for artifact in artifacts {
match suite {
"memory_summary" => {
for entry in artifact
.get("entries")
.and_then(serde_json::Value::as_array)
.into_iter()
.flatten()
{
if let Some(text) = entry.get("text").and_then(serde_json::Value::as_str) {
parts.push(text.to_string());
}
}
},
"proactive_brief" => {
for suggestion in artifact
.get("suggestions")
.and_then(serde_json::Value::as_array)
.into_iter()
.flatten()
{
if let Some(title) = suggestion.get("title").and_then(serde_json::Value::as_str)
{
parts.push(title.to_string());
}
if let Some(body) = suggestion.get("body").and_then(serde_json::Value::as_str) {
parts.push(body.to_string());
}
}
},
"scheduled_memory" => {
for output in artifact
.get("outputs")
.and_then(serde_json::Value::as_array)
.into_iter()
.flatten()
{
if let Some(text) = output.get("text").and_then(serde_json::Value::as_str) {
parts.push(text.to_string());
}
}
},
_ => {},
}
}

if parts.is_empty() {
"Service-native Dreaming readback produced no artifact text.".to_string()
} else {
parts.join(" ")
}
}

fn dreaming_readback_trace_stages(
loaded: &LoadedJob,
evidence: &DreamingReadbackMaterializationEvidence,
) -> Vec<TraceStageOutput> {
vec![
TraceStageOutput {
stage_name: "dreaming_readback.service_list".to_string(),
kept_evidence: evidence.selected_source_refs.clone(),
dropped_evidence: evidence.missing_source_refs.clone(),
demoted_evidence: Vec::new(),
distractor_evidence: Vec::new(),
notes: format!(
"Read {} source refs from ElfService::list for {}.",
evidence.selected_source_refs.len(),
loaded.job.suite
),
},
TraceStageOutput {
stage_name: "dreaming_readback.source_mutation_guard".to_string(),
kept_evidence: evidence.selected_source_refs.clone(),
dropped_evidence: Vec::new(),
demoted_evidence: Vec::new(),
distractor_evidence: Vec::new(),
notes: "Generated readback artifacts without mutating source notes.".to_string(),
},
]
}

async fn service_readback_evidence_ids(
service: &ElfService,
project_id: &str,
Expand All @@ -397,9 +183,7 @@ async fn service_readback_evidence_ids(
let mut evidence_ids = Vec::new();

for item in response.items {
if let Some(evidence_id) =
item.source_ref.get("evidence_id").and_then(serde_json::Value::as_str)
{
if let Some(evidence_id) = item.source_ref.get("evidence_id").and_then(Value::as_str) {
crate::push_unique(&mut evidence_ids, evidence_id.to_string());
}
}
Expand Down
Loading