Skip to content

[Bugfix] Only call scan deinit callback if nimble was stopped. #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
h2zero merged 1 commit into from
Aug 1, 2026
Merged

[Bugfix] Only call scan deinit callback if nimble was stopped. #1178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/NimBLEDevice.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1029,14 +1029,13 @@ bool NimBLEDevice::init(const std::string& deviceName) {
bool NimBLEDevice::deinit(bool clearAll) {
int rc = 0;
if (m_initialized) {
# if MYNEWT_VAL(BLE_ROLE_OBSERVER)
if (NimBLEDevice::m_pScan != nullptr) {
NimBLEDevice::m_pScan->onHostDeinit();
}
# endif

rc = nimble_port_stop();
if (rc == 0) {
# if MYNEWT_VAL(BLE_ROLE_OBSERVER)
if (NimBLEDevice::m_pScan != nullptr) {
NimBLEDevice::m_pScan->onHostDeinit();
}
# endif
nimble_port_deinit();
# ifndef USING_NIMBLE_ARDUINO_HEADERS
# if ESP_IDF_VERSION < ESP_IDF_VERSION_VAL(5, 0, 0)
Expand All @@ -1048,6 +1047,9 @@ bool NimBLEDevice::deinit(bool clearAll) {
# endif
m_initialized = false;
m_synced = false;
} else {
NIMBLE_LOGE(LOG_TAG, "nimble_port_stop() failed with error: %d", rc);
return false;
}
}

Expand Down
Loading