Skip to content

Deduplicate merge queue/main CI attempt 2 - #16478

Open
Jakeii wants to merge 3 commits into
mainfrom
jlk/optimise-merge-queue-ci
Open

Deduplicate merge queue/main CI attempt 2#16478
Jakeii wants to merge 3 commits into
mainfrom
jlk/optimise-merge-queue-ci

Conversation

@Jakeii

@Jakeii Jakeii commented Jul 28, 2026

Copy link
Copy Markdown
Member

What does this change?

This is a second attempt after #16461 was reverted, if a dependant check in needs is skiped, that job will also get skipped by default, we need to explicitly tell it to only skip on failure not if dependant jobs are skipped.

Refine our workflows so that most checks run either in the merge group or on merge to main, as they are run against the exact same commit/code. Demonstrated by the way github shows both push and merge_group results in the PR checks:
Screenshot 2026-07-23 at 09 58 21

So with these changes, jobs now generally run on pull_request and merge_group events, no longer the push event (which runs on push to main or pushes to PRs), just the cicd.yml workflow still runs on push (to main) so that it can publish the artifact to riff-raff.

Why?

Running everything on both is a waste of time/github action compute/chromatic tokens.

@Jakeii
Jakeii force-pushed the jlk/optimise-merge-queue-ci branch 2 times, most recently from e758aae to 9c55a31 Compare July 28, 2026 11:51
Co-authored-by: Copilot <copilot@github.com>
@Jakeii Jakeii added the maintenance Departmental tracking: maintenance work, not a fix or a feature label Jul 28, 2026
@Jakeii
Jakeii force-pushed the jlk/optimise-merge-queue-ci branch from 9c55a31 to ce6e926 Compare July 28, 2026 11:52
@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown

@Jakeii Jakeii added the run_chromatic Runs chromatic when label is applied label Jul 28, 2026
@Jakeii Jakeii added run_chromatic Runs chromatic when label is applied and removed run_chromatic Runs chromatic when label is applied labels Jul 28, 2026
@Jakeii
Jakeii marked this pull request as ready for review July 28, 2026 14:56
@Jakeii
Jakeii requested a review from a team as a code owner July 28, 2026 14:56
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Jul 28, 2026
@Jakeii Jakeii added this to the Health milestone Jul 29, 2026
@Jakeii Jakeii self-assigned this Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Departmental tracking: maintenance work, not a fix or a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants