Handle AudioPlayer inside renderElement - #16456
Merged
Merged
Conversation
frederickobrien
added
the
maintenance
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
github-actions
Bot
removed
the
run_chromatic
frederickobrien
force-pushed
the
handle-audio-player-in-render-element
branch
from
July 24, 2026 19:05
22dffe2 to
d1ea756
Compare
github-actions
Bot
removed
the
run_chromatic
Jakeii
approved these changes
Jul 27, 2026
Jakeii
left a comment
Jakeii
left a comment
Member
There was a problem hiding this comment.
Nice! I don't think there's any reason we don't want these elements rendering in the body as Jamie raised in the original thread
Jakeii
reviewed
Jul 27, 2026
| }) => { | ||
| const { renderingTarget } = useConfig(); | ||
| const isApps = renderingTarget === 'Apps'; | ||
| const audioData = getAudioData([element]); |
Member
There was a problem hiding this comment.
Non-blocking, but does get audio data still need to accept an array?
Contributor
Author
There was a problem hiding this comment.
Afraid so, everywhere else it's used it takes the full array of main media elements
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Jul 28, 2026
frederickobrien
force-pushed
the
handle-audio-player-in-render-element
branch
from
July 28, 2026 08:55
d1ea756 to
5d2eb90
Compare
github-actions
Bot
removed
the
run_chromatic
|
Seen on PROD (merged by @frederickobrien 12 minutes and 2 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A further spinoff from #16133, this moves the rendering logic for
AudioPlayerinsiderenderElement. Tidy!