fix: resolve symlinks before computing DIR for venv lookup - #1
Open
griffincapmisc wants to merge 1 commit into
Open
fix: resolve symlinks before computing DIR for venv lookup#1griffincapmisc wants to merge 1 commit into
griffincapmisc wants to merge 1 commit into
Conversation
When the ga entrypoint is invoked via a symlink (standard AFK plugin install path), $(dirname "$0") returns the symlink's directory, not the target's. This means the venv-relative paths never match and the wrapper silently falls back to system Python — which may not have the required packages (e.g. after a Homebrew Python major-version upgrade). Resolve the symlink chain before computing DIR so the venv is found regardless of how the script is called.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
gaentrypoint is invoked via a symlink (the standard AFK plugin install path —~/.afk/skills/ga/scripts/ga → plugins/ga-cli/skills/ga/scripts/ga),$(dirname "$0")returns the symlink's directory, not the target's. This means the venv-relative paths ($DIR/../../../.venv,$DIR/../.venv) never match, and the wrapper silently falls back to system Python.This breaks when the system Python upgrades (e.g. Homebrew 3.9 → 3.13) and pip packages are stranded in the old site-packages.
Fix: Resolve the symlink chain before computing
DIR, matching POSIXreadlinkbehavior. The venv is now found regardless of how the script is called.