Expose a unified KKT layout interface - #72
Merged
Conversation
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
cameronkhanpour
marked this pull request as ready for review
August 11, 2026 14:11
samtalki
self-requested a review
August 12, 2026 00:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kkt_layoutas the primary KKT shape interface.kkt_dimsandkkt_indicesas thin, backward-compatible conveniences.Why
KKT dimensions and named index ranges were exposed through separate entry points even though callers commonly need both. Returning them together establishes one source of truth and prevents the two views of a layout from drifting apart.
Impact
Callers can now use
dim, idx = kkt_layout(net_or_prob)uniformly for DC and AC systems. Existingkkt_dimsandkkt_indicescalls, including the legacy integer overloads, remain supported.Validation
julia --project=. -e "using Pkg; Pkg.test()"SITE_BUILD=true julia --project=docs docs/make.jlCloses #62