Fix Stream.closeWritable to await close completion - #133
Merged
Conversation
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Stream.closeWritableto await close completion and surface errorsProblem
_Stream_closeWritableinsrc/Gren/Kernel/Stream.jswas fire-and-forget:writer.close()returns a promise that settles only once the underlying sink has actually closed. By ignoring it, the function had two correctness bugs:Taskresolved synchronously — before the stream had actually closed. Any caller chaining on the result (Task.andThen) would proceed as though the stream were closed when it wasn't yet.writer.close()promise rejected with no listener. The unhandled rejection was lost, and theTaskstill reported success — callers could never learn the close failed.Fix
Await
writer.close()and route its outcome to the Scheduler callback:The
.catchpath reuses the existing_Stream_cancellationErrorStringhelper, matching how_Stream_readalready reports failures asStream.Cancelled.Behavior changes
closeWritablenow resolves only after the stream has actually closed, so chained tasks observe correct sequencing.Stream.Cancelled <message>instead of being swallowed and falsely reported as success.close()settles (in both branches), rather than synchronously before close completes.