Skip to content

WC-1931:lf_interop_ping_plotter.py: Fix ping test generic tab check #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
haricharan-candela wants to merge 1 commit into from
Closed

WC-1931:lf_interop_ping_plotter.py: Fix ping test generic tab check #360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions py-scripts/lf_interop_ping_plotter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,9 +431,8 @@ def check_tab_exists(self):
response = self.json_get("generic")
if response is None:
logger.error("GET /generic returned no response; Generic tab may not be available on the LANforge manager.")
return False
else:
return True
raise RuntimeError("Generic tab is not available on the LANforge manager.")
return True

def create_generic_endp(self):
# Virtual stations are tracked in same list as real stations, so need to separate them
Expand Down Expand Up @@ -3486,9 +3485,7 @@ def main():
ping.buildstation()

# check if generic tab is enabled or not
if not ping.check_tab_exists():
logging.error('Generic Tab is not available.\nAborting the test.')
exit(0)
ping.check_tab_exists()

ping.sta_list += ping.real_sta_list

Expand Down
Loading