Harden deploy preview trust boundary - #60
Draft
magicmark wants to merge 10 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #40's privileged deploy path currently treats fork branch names as shell source and identifies pull requests by branch name alone, which lets untrusted input cross into the secret-bearing job.
This stack resolves pull requests using repository, branch, SHA, and base identity; rejects stale, ambiguous, and deployment-config artifacts; serializes deploys; and pins an exact Wrangler version. The focused regression coverage includes a Git-valid branch name containing shell metacharacters and now runs in the normal repository validation workflow.
Draft PR: This PR was sent by Claude and may not have yet been reviewed by mark.