Skip to content

releasing mutex in get_umem - #4

Open
spotluri wants to merge 1 commit into
peermemfrom
peermem-fix-mutex
Open

releasing mutex in get_umem#4
spotluri wants to merge 1 commit into
peermemfrom
peermem-fix-mutex

Conversation

@spotluri

@spotluri spotluri commented Jun 2, 2017

Copy link
Copy Markdown

This path acquires the mutex but does not release it, causing a deadlock.

@spotluri
spotluri requested a review from drossetti June 2, 2017 06:32
@spotluri

Copy link
Copy Markdown
Author

@drossetti: does this look reasonable to you? If so, is it ok to merge into peermem?

@drossetti

Copy link
Copy Markdown

It does not look right to me

@spotluri

spotluri commented Jun 15, 2017

Copy link
Copy Markdown
Author

@davide, thanks for taking a look. Looking back at it, I do see multiple issues with the patch :-(

should the lock just be released here, without removing the context?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants