fix(api_client): explicitly close connections and clear large response buffers to prevent memory leaks - #2900
Open
x-tahosin wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
x-tahosin
force-pushed
the
bugfix-memory-leak-2369
branch
from
August 23, 2026 17:07
91f0f86 to
3e60c74
Compare
…d growth Fixes googleapis#2369. When using generate_content(stream=False), the SDK extracts the text from the response and wraps it in a list inside HttpResponse. However, the underlying httpx.Response or aiohttp.ClientResponse can be kept alive by exceptions or internal async event loop state. For responses containing large strings (e.g. base64 images), this causes a significant memory leak. This change ensures that once the text is read, we explicitly close the connection and clear large string buffers from the response objects.
x-tahosin
force-pushed
the
bugfix-memory-leak-2369
branch
from
August 23, 2026 17:14
3e60c74 to
346f7b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running multiple async generation requests, the
google-genaiSDK leaks memory. The underlyinghttpxoraiohttpresponse objects accumulate in memory because they are not explicitly closed after the text is read. This causes unbounded memory growth over time.Fix implemented
I modified
google/genai/_api_client.pyto eagerly release network resources. For non streaming responses, as soon asresponse.text()is read, the patch explicitly callsclose()orrelease()on the response object and clears out the internal_contentbuffers.Steps to Reproduce
Run a loop doing
await client.aio.models.generate_content(...). Checktracemalloc. You will seehttpx.Responseand raw bytes accumulating in memory. After this patch, memory stays flat.