Skip to content

fix: omit stream query parameter when stream is None on interactions get #2886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adi-IL wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: omit stream query parameter when stream is None on interactions get #2886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions google/genai/_gaos/google_genai.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,15 +296,15 @@ def get(
api_version: Optional[str] = None,
include_input: Any = None,
last_event_id: Any = None,
stream: Any = False,
stream: Any = None,
extra_headers: Optional[Mapping[str, str]] = None,
extra_query: Optional[Mapping[str, Any]] = None,
timeout: Optional[Union[float, httpx.Timeout]] = None,
) -> Union[
interactions.Interaction,
eventstreaming.Stream[interactions.InteractionSSEEvent],
]:
stream_bool = bool(_optional_bool(stream, default=False))
stream_bool = _optional_bool(stream)
response = wrap_sdk_call(
super().get,
id=id,
Expand Down Expand Up @@ -448,15 +448,15 @@ async def get(
api_version: Optional[str] = None,
include_input: Any = None,
last_event_id: Any = None,
stream: Any = False,
stream: Any = None,
extra_headers: Optional[Mapping[str, str]] = None,
extra_query: Optional[Mapping[str, Any]] = None,
timeout: Optional[Union[float, httpx.Timeout]] = None,
) -> Union[
interactions.Interaction,
eventstreaming.AsyncStream[interactions.InteractionSSEEvent],
]:
stream_bool = bool(_optional_bool(stream, default=False))
stream_bool = _optional_bool(stream)
response = await async_wrap_sdk_call(
super().get,
id=id,
Expand Down
28 changes: 28 additions & 0 deletions google/genai/tests/interactions/test_paths.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,22 @@ def test_interactions_paths(mock_auth_default, client):
client.interactions.get(id=interaction_id)
mock_send.assert_called_once()
request = mock_send.call_args[0][0]
assert str(request.url) == f'{expected_base_url}/interactions/{interaction_id}'

mock_send.reset_mock()
mock_send.return_value = Response(200, request=Request('GET', ''), headers={'content-type': 'application/json'}, content='{"status": "completed"}')
client.interactions.get(id=interaction_id, stream=False)
mock_send.assert_called_once()
request = mock_send.call_args[0][0]
assert str(request.url) == f'{expected_base_url}/interactions/{interaction_id}?stream=false'

mock_send.reset_mock()
mock_send.return_value = Response(200, request=Request('GET', ''), headers={'content-type': 'application/json'}, content='{"status": "completed"}')
client.interactions.get(id=interaction_id, stream=True)
mock_send.assert_called_once()
request = mock_send.call_args[0][0]
assert str(request.url) == f'{expected_base_url}/interactions/{interaction_id}?stream=true'

mock_send.reset_mock()
mock_send.return_value = Response(200, request=Request('POST', ''), headers={'content-type': 'application/json'}, content='{"status": "completed"}')
client.interactions.cancel(id=interaction_id)
Expand Down Expand Up @@ -90,8 +104,22 @@ async def test_async_interactions_paths(mock_auth_default, client):
await client.aio.interactions.get(id=interaction_id)
mock_send.assert_called_once()
request = mock_send.call_args[0][0]
assert str(request.url) == f'{expected_base_url}/interactions/{interaction_id}'

mock_send.reset_mock()
mock_send.return_value = Response(200, request=Request('GET', ''), headers={'content-type': 'application/json'}, content='{"status": "completed"}')
await client.aio.interactions.get(id=interaction_id, stream=False)
mock_send.assert_called_once()
request = mock_send.call_args[0][0]
assert str(request.url) == f'{expected_base_url}/interactions/{interaction_id}?stream=false'

mock_send.reset_mock()
mock_send.return_value = Response(200, request=Request('GET', ''), headers={'content-type': 'application/json'}, content='{"status": "completed"}')
await client.aio.interactions.get(id=interaction_id, stream=True)
mock_send.assert_called_once()
request = mock_send.call_args[0][0]
assert str(request.url) == f'{expected_base_url}/interactions/{interaction_id}?stream=true'

mock_send.reset_mock()
mock_send.return_value = Response(200, request=Request('POST', ''), headers={'content-type': 'application/json'}, content='{"status": "completed"}')
await client.aio.interactions.cancel(id=interaction_id)
Expand Down
Loading