Skip to content

refactor(gax): extract make_credentials and add_auth_headers#6003

Open
joshuatants wants to merge 1 commit into
googleapis:mainfrom
joshuatants:grpc-rust-helpers-extraction
Open

refactor(gax): extract make_credentials and add_auth_headers#6003
joshuatants wants to merge 1 commit into
googleapis:mainfrom
joshuatants:grpc-rust-helpers-extraction

Conversation

@joshuatants

@joshuatants joshuatants commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

For #5991

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the gRPC client by moving the make_credentials and add_auth_headers helper functions from grpc.rs to grpc_helpers.rs and adding corresponding unit tests. The feedback suggests replacing .unwrap() with .expect() in the newly added tests to comply with the repository's style guide regarding error handling in tests.

Comment thread src/gax-internal/src/grpc/grpc_helpers.rs Outdated
@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.71%. Comparing base (5a966c5) to head (3f5d199).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/gax-internal/src/grpc/grpc_helpers.rs 98.83% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6003   +/-   ##
=======================================
  Coverage   97.71%   97.71%           
=======================================
  Files         244      244           
  Lines       61074    61139   +65     
=======================================
+ Hits        59680    59744   +64     
- Misses       1394     1395    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joshuatants joshuatants force-pushed the grpc-rust-helpers-extraction branch from 25b8e33 to 3f5d199 Compare July 8, 2026 07:12
@joshuatants joshuatants marked this pull request as ready for review July 8, 2026 07:43
@joshuatants joshuatants requested a review from a team as a code owner July 8, 2026 07:43

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No action needed: I do not like the grpc_ prefix in this file, it is redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants