refactor(gax): extract make_credentials and add_auth_headers#6003
refactor(gax): extract make_credentials and add_auth_headers#6003joshuatants wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the gRPC client by moving the make_credentials and add_auth_headers helper functions from grpc.rs to grpc_helpers.rs and adding corresponding unit tests. The feedback suggests replacing .unwrap() with .expect() in the newly added tests to comply with the repository's style guide regarding error handling in tests.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6003 +/- ##
=======================================
Coverage 97.71% 97.71%
=======================================
Files 244 244
Lines 61074 61139 +65
=======================================
+ Hits 59680 59744 +64
- Misses 1394 1395 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
25b8e33 to
3f5d199
Compare
There was a problem hiding this comment.
No action needed: I do not like the grpc_ prefix in this file, it is redundant.
For #5991