feat(storage): make GrpcRustClient available as a transport option#6000
Draft
joshuatants wants to merge 1 commit into
Draft
feat(storage): make GrpcRustClient available as a transport option#6000joshuatants wants to merge 1 commit into
joshuatants wants to merge 1 commit into
Conversation
product-auto-label
Bot
added
the
api: storage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces conditional compilation support for an unstable gRPC Rust client implementation (google_cloud_unstable_grpc_rust) in the storage service. It conditionally defines the GrpcClient and GrpcStream types for both bidirectional read and write operations, falling back to the standard gaxi::grpc::Client and tonic::Streaming types when the feature is not enabled. There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #5991.
DOES NOT BUILD. Awaiting #5999 . Created this PR to show the intent of that PR.