feat(storage): add tracing and decorators#5963
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for bidirectional streaming writes (Bidi Write) for appendable objects in the Google Cloud Storage client. It adds new request builders (OpenAppendableObject and ReopenAppendableObject), a background stream worker, and transport/connector logic to manage handshakes and redirects. Feedback on these changes suggests avoiding unnecessary string allocations by passing string literals directly to builder methods, and improving error handling by creating specific error variants instead of wrapping conversion errors in generic I/O errors.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5963 +/- ##
==========================================
- Coverage 97.72% 97.52% -0.20%
==========================================
Files 242 250 +8
Lines 60882 62612 +1730
==========================================
+ Hits 59495 61061 +1566
- Misses 1387 1551 +164 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
I am not even looking at a 3300+ line of code PR. |
No description provided.