Skip to content

feat(storage): add tracing and decorators#5963

Open
vsharonlynn wants to merge 13 commits into
googleapis:mainfrom
vsharonlynn:appendable_upload_5
Open

feat(storage): add tracing and decorators#5963
vsharonlynn wants to merge 13 commits into
googleapis:mainfrom
vsharonlynn:appendable_upload_5

Conversation

@vsharonlynn

Copy link
Copy Markdown
Contributor

No description provided.

@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Jun 30, 2026
@vsharonlynn vsharonlynn changed the title feat(storage): add tracing and decorators @vsharonlynn feat(storage): add tracing and decorators Jun 30, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for bidirectional streaming writes (Bidi Write) for appendable objects in the Google Cloud Storage client. It adds new request builders (OpenAppendableObject and ReopenAppendableObject), a background stream worker, and transport/connector logic to manage handshakes and redirects. Feedback on these changes suggests avoiding unnecessary string allocations by passing string literals directly to builder methods, and improving error handling by creating specific error variants instead of wrapping conversion errors in generic I/O errors.

Comment thread src/storage/examples/src/lib.rs
Comment thread src/storage/src/storage/bidi_write/connector.rs
@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.33054% with 209 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.52%. Comparing base (5e91002) to head (aed02a5).
⚠️ Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
src/storage/src/storage/open_appendable_object.rs 45.04% 111 Missing ⚠️
...rc/storage/src/storage/reopen_appendable_object.rs 68.64% 37 Missing ⚠️
src/storage/src/storage/stub.rs 0.00% 18 Missing ⚠️
src/storage/src/storage/bidi_write/worker.rs 87.50% 16 Missing ⚠️
src/storage/src/storage/bidi_write/connector.rs 98.03% 10 Missing ⚠️
src/storage/src/storage/transport.rs 97.43% 7 Missing ⚠️
src/storage/src/storage/bidi_write/transport.rs 98.01% 6 Missing ⚠️
src/storage/src/storage/bidi_write/redirect.rs 95.50% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5963      +/-   ##
==========================================
- Coverage   97.72%   97.52%   -0.20%     
==========================================
  Files         242      250       +8     
  Lines       60882    62612    +1730     
==========================================
+ Hits        59495    61061    +1566     
- Misses       1387     1551     +164     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vsharonlynn vsharonlynn marked this pull request as ready for review June 30, 2026 06:47
@vsharonlynn vsharonlynn requested review from a team as code owners June 30, 2026 06:47
@coryan

coryan commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

I am not even looking at a 3300+ line of code PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants