fix: treat empty string/bytes as NULL in NullUUID.Scan - #222
Closed
sonnemusk wants to merge 1 commit into
Closed
Conversation
UUID.Scan("") succeeds with a Nil UUID, so NullUUID.Scan previously set
Valid=true for empty DB values. Treat empty string and empty []byte as
SQL NULL (Valid=false), matching NullUUID.Scan(nil). Fixes #109.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
sonnemusk
force-pushed
the
fix/nulluuid-scan-empty-string
branch
from
July 22, 2026 07:55
57a2a62 to
203a75e
Compare
Author
|
Closing this PR as low-signal noise after a quality pass on open contributions. Sorry for the distraction — focusing on fewer, higher-impact fixes going forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`NullUUID.Scan("")` (and empty `[]byte`) previously set `Valid=true` with a Nil UUID because `UUID.Scan` treats empty as success without error.
Empty database values should behave like SQL NULL: `Valid=false`, `UUID=Nil`.
Fixes #109.
Test plan