Adopt the caller's device block when re-inserting an HBM-only entry. - #728
Open
copybara-service[bot] wants to merge 1 commit into
Open
Adopt the caller's device block when re-inserting an HBM-only entry.#728copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
An entry that is only in HBM describes a device block and nothing else: no host bytes were ever written for it. When a save gives up, that entry is left behind pointing at a device block the caller then reuses, so a later save driven from it would copy unrelated bytes and the hash could never be admitted again. Re-inserting such a hash now takes the caller's binding, which is the only current one. Entries that hold host bytes are still pinned in place and left untouched. PiperOrigin-RevId: 967610679
copybara-service
Bot
force-pushed
the
test_967610679
branch
from
August 20, 2026 09:31
cb3b139 to
8b2b2a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopt the caller's device block when re-inserting an HBM-only entry.
An entry that is only in HBM describes a device block and nothing else: no host bytes were ever written for it. When a save gives up, that entry is left behind pointing at a device block the caller then reuses, so a later save driven from it would copy unrelated bytes and the hash could never be admitted again.
Re-inserting such a hash now takes the caller's binding, which is the only current one. Entries that hold host bytes are still pinned in place and left untouched.