Support FullMatch on pre-compiled Regex in regex wrapper - #75
Open
copybara-service[bot] wants to merge 1 commit into
Open
Support FullMatch on pre-compiled Regex in regex wrapper#75copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
Add support for calling `FullMatch` and `FullMatchN` with pre-compiled `const Regex&` objects in `//security/regex`. - In `regex.h`, implement `FullMatchN` and `FullMatch(absl::string_view, const Regex&, Args&&...)` by matching the full span (`Start() == 0 && End() == text.size()`) of the pre-compiled regex without requiring recompilation. - Clean up single-letter variable names across template matching functions. - Add unit tests verifying `FullMatch` on pre-compiled `Regex` objects with and without capture group extractions and numeric parsing. PiperOrigin-RevId: 967070596
copybara-service
Bot
force-pushed
the
test_967070596
branch
from
August 19, 2026 09:43
689f979 to
268c8fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support FullMatch on pre-compiled Regex in regex wrapper
Add support for calling
FullMatchandFullMatchNwith pre-compiledconst Regex&objects in//security/regex.regex.h, implementFullMatchNandFullMatch(absl::string_view, const Regex&, Args&&...)by matching the full span (Start() == 0 && End() == text.size()) of the pre-compiled regex without requiring recompilation.FullMatchon pre-compiledRegexobjects with and without capture group extractions and numeric parsing.