Add test enforcing host references in redemption domains#3109
Conversation
|
You can't outsource all your thinking to the AI ... We can't prohibit a domain restore operation during the redemption grace period. It's part of our mandated ICANN lifecycle. The resolution that makes sense to me is restoring the domain, but with the now-deleted host(s) removed. The domain has to be restorable, then it's up to the registrar to put new nameservers on it that are still valid. |
I'm a bit insulted that you'd think I outsourced my thinking to the AI. It's not as clear as that. The RFCs also forbid changing a domain as part of a domain:restore. From 3915 4.2.5: And generally it's better to have loud failures than quiet modifications. |
Domains in the redemption grace period can still be restored, so hosts referencing them cannot be deleted. Fortunately this is already the case. This just adds a test.
901230e to
556f1fa
Compare
|
This is moot. We forbid host deletion. But just in case this'll add a test. |
CydeWeys
left a comment
There was a problem hiding this comment.
@CydeWeys reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on gbrodman).
Domains in the redemption grace period can still be restored, so hosts
referencing them cannot be deleted. Fortunately this is already the
case. This just adds a test.
This change is