Add test for perm check for EPP password changes#3099
Conversation
b5c4844 to
8e33b48
Compare
ptkach
left a comment
There was a problem hiding this comment.
@ptkach reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on gbrodman).
core/src/main/java/google/registry/ui/server/console/ConsoleEppPasswordAction.java line 96 at r1 (raw file):
} checkPermission(user, eppRequestBody.registrarId, ConsolePermission.EDIT_REGISTRAR_DETAILS);
I think https://github.com/google/nomulus/pull/3076/changes already checks permission
8e33b48 to
0976cb5
Compare
0976cb5 to
1c952f6
Compare
gbrodman
left a comment
There was a problem hiding this comment.
@gbrodman made 1 comment.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on ptkach).
core/src/main/java/google/registry/ui/server/console/ConsoleEppPasswordAction.java line 96 at r1 (raw file):
Previously, ptkach (Pavlo Tkach) wrote…
I think https://github.com/google/nomulus/pull/3076/changes already checks permission
So it did. I wasn't aware of that / it hadn't merged. But that didn't add tests (which this now does)
This change is