fix(ui): Add 'Would you still like to continue?' to performance warning dialogs- - #138
Open
rund77 wants to merge 1 commit into
Open
fix(ui): Add 'Would you still like to continue?' to performance warning dialogs-#138rund77 wants to merge 1 commit into
rund77 wants to merge 1 commit into
Conversation
rund77
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the Files scanning tool, enabling either 'Include Historical File Versions in Corpus Size' or 'Scan for Encrypted Files (RMS/MIP)' brings up a warning dialog with Yes / No buttons. However, the message was previously just a statement without a clear question at the end, which felt a bit awkward next to the Yes/No buttons.
This PR adds a quick sentence at the end of the warning: "Would you still like to continue?" so the dialog flows naturally and makes it clear what Yes and No actually do.
Also added the same line to the Exchange Online encrypted email warning for consistency.