Localize the stop condition to make it more library-friendly.#2105
Open
copybara-service[bot] wants to merge 1 commit into
Open
Localize the stop condition to make it more library-friendly.#2105copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
cl/936759616
branch
from
4b5c156 to
3f40106
Compare
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
cl/936759616
branch
3 times, most recently
from
356f8fe to
088c01a
Compare
Otherwise, when invoking the library interface, one invocation that triggers an early stop can affect other invocations. Also currently the library call installs signal handlers, which is global and can conflict with existing handlers. Moved the signal handling from the library to the binary entry code. The main library entry CentipedeMain takes an optional StopCondition to allow early stop to be requested externally (from the signal handlers). PiperOrigin-RevId: 936759616
copybara-service
Bot
force-pushed
the
cl/936759616
branch
from
088c01a to
327949a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Localize the stop condition to make it more library-friendly.
Otherwise, when invoking the library interface, one invocation that triggers an early stop can affect other invocations. Also currently the library call installs signal handlers, which is global and can conflict with existing handlers.
Moved the signal handling from the library to the binary entry code.
The main library entry CentipedeMain takes an optional StopCondition to allow early stop to be requested externally (from the signal handlers).