Exclude haiku doctests from CI#5532
Open
samanklesaria wants to merge 1 commit into
Open
Conversation
IvyZX
requested changes
Jul 23, 2026
IvyZX
left a comment
IvyZX
left a comment
Collaborator
There was a problem hiding this comment.
Approach LGTM. But the CI doctest is still broken?
Collaborator
Author
It seems there's an NNX version of the haiku migration guide as well. I'll exclude that from doctests too. |
samanklesaria
force-pushed
the
drop_haiku_doctest
branch
from
July 23, 2026 17:24
631d9b8 to
36517f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the CI's recent doctest failures. Currently, we get "AttributeError: jax.core.DropVar was deprecated in JAX v0.10.0 and removed in JAX v0.11.0." when running doctests. This is actually a problem with haiku: (dm-haiku==0.0.16's jaxpr_info.py:45 still references jax.core.DropVar, which the latest jax removed). The simplest fix is to just not run guides/converting_and_upgrading/haiku_migration_guide during doctest CI.