Expose relational synthesis API on top-level dpsynth and strengthen MultiTableConfig eager validation. - #148
Open
copybara-service[bot] wants to merge 1 commit into
Open
Expose relational synthesis API on top-level dpsynth and strengthen MultiTableConfig eager validation.#148copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…ultiTableConfig eager validation.
- Public API Packaging:
* Export essential multi-table relational synthesis constructs (`MultiTableConfig`, `MultiTableMechanism`, `MultiDataGenerationResult`, `ForeignKeyRelation`) directly on `dpsynth` and `dpsynth.relational`.
* Update dependencies.
- Eager MultiTableConfig.__post_init__ Validation:
* Make `foreign_keys` a required argument with no default (`= ()` removed).
* Enforce naming constraints: reject table/column names containing '.' and reserved keywords ('group_size', 'slot_*').
* Enforce schema invariants: reject empty table schemas and ensure all attributes are instances of NumericalAttribute, CategoricalAttribute, or OpenSetCategoricalAttribute.
* Validate DAG hierarchy eagerly via `topological_sort_hierarchy` to immediately reject cycles, self-loops, multiple parents (in-degree > 1), and multi-root forests.
* Enforce strict separation between relational key columns (PK/FK) and statistical domain schemas.
* Validate custom initializer mappings (if provided) against domain tables and columns.
* Enforce open interval hyperparameter bounds (0.0 < init_budget_fraction < 1.0).
- Testing:
* Add unit tests for public module exports in `synthesizer_test.py`.
* Add parameterized subtests covering all eager `MultiTableConfig.__post_init__` validation failures.
PiperOrigin-RevId: 967438848
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose relational synthesis API on top-level dpsynth and strengthen MultiTableConfig eager validation.
Public API Packaging:
MultiTableConfig,MultiTableMechanism,MultiDataGenerationResult,ForeignKeyRelation) directly ondpsynthanddpsynth.relational.Eager MultiTableConfig.post_init Validation:
foreign_keysa required argument with no default (= ()removed).topological_sort_hierarchyto immediately reject cycles, self-loops, multiple parents (in-degree > 1), and multi-root forests.Testing:
synthesizer_test.py.MultiTableConfig.__post_init__validation failures.