Skip to content

hwcaps: dont return an uninitialized hwcap on elf_aux_info failure #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EylonKrause wants to merge 1 commit into
base: main
Choose a base branch
from
Open

hwcaps: dont return an uninitialized hwcap on elf_aux_info failure #466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/hwcaps_freebsd_or_openbsd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,11 @@ const char* CpuFeatures_GetBasePlatformPointer(void);
#include <sys/auxv.h>

static unsigned long GetElfHwcapFromElfAuxInfo(int hwcap_type) {
unsigned long hwcap;
elf_aux_info(hwcap_type, &hwcap, sizeof(hwcap));
unsigned long hwcap = 0;
// elf_aux_info() leaves the output buffer untouched and returns non-zero when
// the requested entry is absent (e.g. AT_HWCAP2 on some arch/kernel combos),
// so return 0 instead of an indeterminate value.
if (elf_aux_info(hwcap_type, &hwcap, sizeof(hwcap)) != 0) return 0;
return hwcap;
}

Expand Down