Migrate Android Build API usage to V4 OnePlatform under feature flag#5335
Open
dylanjew wants to merge 3 commits into
Open
Migrate Android Build API usage to V4 OnePlatform under feature flag#5335dylanjew wants to merge 3 commits into
dylanjew wants to merge 3 commits into
Conversation
dylanjew
force-pushed
the
dylanj/migrate-android-build-api-v4
branch
from
4150bc7 to
a447267
Compare
The legacy Android Build API V3 (androidbuildinternal.googleapis.com) is being sunsetted. This CL migrates the client calls to the new V4 Private API (androidbuild-pa.googleapis.com) using standard discovery. Changes: - Added a 'use_android_build_api_v4' Datastore Config property to allow runtime feature toggle. - Refactored 'fetch_artifact.py' to support V4 OnePlatform endpoint and resource names dynamically behind the feature flag. - Migrated legacy logs to structured dictionary-based logs with '[AndroidBuildAPI]' tagging for easier Cloud Logging filtering.
dylanjew
force-pushed
the
dylanj/migrate-android-build-api-v4
branch
from
81a66d1 to
2393e4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the Android Build API client calls from legacy V3 (androidbuildinternal.googleapis.com) to the new V4 Private API (androidbuild-pa.googleapis.com) using standard OnePlatform discovery.
Changes:
Added a new Datastore Config property 'use_android_build_api_v4' to the Config model class to support runtime toggle of the API version.
Updated 'fetch_artifact.py' to conditionally initialize and use either the V3 or V4 client/endpoints depending on the Datastore feature flag.
Refactored logs to use structured dictionary-based entries with the '[AndroidBuildAPI]' tag to facilitate filtering and diagnosis in Cloud Logging.
Patched in #5327, fixed formatting, lint and added TODO to clean up