Enforce TZ_MAX_TYPES limit and use size_t for iteration in TimeZoneInfo::Load() to avoid wrap-around at 256#346
Merged
mkruskal-google merged 1 commit intoJul 11, 2026
Conversation
higher-performance
force-pushed
the
tzif-parser-wraparound
branch
from
e401958 to
da64b9b
Compare
mkruskal-google
approved these changes
Jul 10, 2026
higher-performance
force-pushed
the
tzif-parser-wraparound
branch
from
da64b9b to
229f028
Compare
mkruskal-google
approved these changes
Jul 11, 2026
mkruskal-google
approved these changes
Jul 11, 2026
Collaborator
Author
|
Actually it seems I might not have merge permissions at all. Do you want to merge, or give me permissions? |
devbww
suggested changes
Jul 11, 2026
…::Load() from uint8_fast_t to size_t to avoid wrap-around at 256 Otherwise there is a potential denial-of-service vulnerability using a crafted zoneinfo file that has 256 or more transition types that are all marked as DST.
higher-performance
force-pushed
the
tzif-parser-wraparound
branch
from
ba98ac8 to
66b70a7
Compare
devbww
reviewed
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise there is a potential denial-of-service vulnerability using a crafted zoneinfo file that has 256 or more transition types that are all marked as DST.