reject header varint field sent as section - #157
Open
zayeem06 wants to merge 1 commit into
Open
Conversation
Collaborator
|
Please sort includes (put |
Contributor
Author
|
Done, moved the brunsli headers to the top and sorted them. |
eustas
approved these changes
Jul 9, 2026
Contributor
Author
|
any update? |
Collaborator
|
Terribly sorry, please rebase again. I've fixed pipelines just recently and added linter |
eustas
previously approved these changes
Aug 19, 2026
zayeem06
force-pushed
the
header-field-wire-type
branch
from
August 20, 2026 07:18
2cb097e to
5ac5587
Compare
Contributor
Author
|
Rebased onto master and squashed into one commit. Ran clang-format so the includes pass the new linter, and the c_api_test still passes locally. |
zayeem06
force-pushed
the
header-field-wire-type
branch
from
August 20, 2026 07:21
5ac5587 to
6ff4676
Compare
Contributor
Author
|
No worries. Rebased on latest master, resolved the include conflict (brunsli headers up top, standard ones after), and c_api_test still passes locally. |
eustas
approved these changes
Aug 20, 2026
Collaborator
|
Almost. Just a tiny formatting issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DecodeHeader rejects a width/height/version/subsampling field that arrives as a length-delimited section by calling Fail without returning, so a crafted header slips past the check and the field value is left unset in varint_values and read later on. Adding the missing return rejects the stream with BRUNSLI_INVALID_BRN, in line with every other check in the function. I also added a small decode test that feeds such a header and asserts it is rejected.