cast to unsigned char before isdigit in ar member parsing - #504
Open
fr-manvi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bloaty can open static
.aarchives, and ArFile::MemberReader::ReadMember reads the 16-byte member name straight out of the file. When a name begins with '/' the code calls isdigit(file_id[1]) to distinguish a long-filename reference from the symbol table and the long-name table. file_id[1] is a plain char, so on a platform where char is signed a name byte with the high bit set reaches isdigit as a negative int, and the ctype functions are only defined for arguments representable as unsigned char or EOF. I ran into it building a small.aby hand whose member name was "/\x80"; glibc happens to fold that to the correct answer, but a stricter CRT indexes its ctype table with the negative value and reads outside it. Casting to unsigned char before the call keeps the argument in range. This is the only ctype call in the tree, so nothing else needs the same fix.