Preserve staticmethod when AutoTracingPlugin rebinds class members - #6820
Open
Hashim1999164 wants to merge 1 commit into
Open
Preserve staticmethod when AutoTracingPlugin rebinds class members#6820Hashim1999164 wants to merge 1 commit into
Hashim1999164 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AutoTracingPlugin rebound class members from inspect.getmembers, which unwraps a staticmethod to a plain function. setattr then stored that function, so instance access bound self as the first argument and calls such as C().static(a=1) raised TypeError.
_rebind now checks the class dict and rewraps staticmethod (and classmethod) before setattr.
Closes #6819
Testing Plan
pytest tests/unittests/plugins/test_auto_tracing_plugin.py::test_staticmethod_does_not_bind_instance
pytest tests/unittests/plugins/test_auto_tracing_plugin.py::test_emits_span
5 passed locally.
Manual E2E: N/A. This is descriptor rebinding only; no agent UI or runner flow change.