fix: avoid setting Part.partMetadata when metadata is empty - #1439
Open
hemasekhar-p wants to merge 1 commit into
Open
fix: avoid setting Part.partMetadata when metadata is empty#1439hemasekhar-p wants to merge 1 commit into
hemasekhar-p wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
PartConverter.toGenaiPart()unconditionally setsPart.Builder#partMetadata(), which the GenAI SDK rejects on Vertex AI / Gemini Enterprise Agent Platform #1421Problem:
In
PartConverter.java,toGenaiPart()andconvertFilePartToGenAiPart()unconditionally setPart.Builder#partMetadata(...)whenever the A2A part's metadata map was non-null (textPart.getMetadata() != nullandfilePart.getMetadata() != null). BecausePartConverter.fromGenaiPart()initializes A2A parts with default empty metadata maps ({}), any round-tripped or converted A2A message attached empty metadata{}toPart#partMetadata.Solution:
PartConverter#toGenaiPart(forTextPart) to only callpartBuilder.partMetadata(...)whentextPart.getMetadata() != null && !textPart.getMetadata().isEmpty().PartConverter#convertFilePartToGenAiPart(forFileWithUriandFileWithBytes) to checkmetadata != null && !metadata.isEmpty()before callingbuilder.partMetadata(metadata).PartConverterTestto verify thatTextPartandFilePartwith empty metadata maps do not setPart.partMetadata.Testing Plan
Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.
Unit Tests:
Checklist