improve(asserts): clarify bare Ellipsis usage in assert_shape error - #464
Open
erensh27 wants to merge 1 commit into
Open
improve(asserts): clarify bare Ellipsis usage in assert_shape error#464erensh27 wants to merge 1 commit into
erensh27 wants to merge 1 commit into
Conversation
Passing directly to assert_shape raised 'expected shapes should be a list or tuple of ints, got Ellipsis', which implies a type mistake even though is a valid wildcard shape. Special-case Ellipsis in the error message and point users at the form.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvement for #437: a bare Ellipsis passed as
expected_shapesnow gets a dedicated hint in the error message, instead of the generic type complaint which made users think...was unsupported.Added a regression test (
test_bare_ellipsis_message_suggests_tuple_form) in asserts_test.py. No other behavior changed:(...,)still works as before.