zmu/gdai 1929 genai sse transient retry#1667
Merged
Merged
Conversation
zdenekmusil-gd
force-pushed
the
zmu/gdai-1929-genai-sse-transient-retry
branch
from
f77ae37 to
d675811
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1667 +/- ##
=======================================
Coverage 79.21% 79.21%
=======================================
Files 232 232
Lines 15809 15809
=======================================
Hits 12523 12523
Misses 3286 3286 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
hkad98
reviewed
Jun 19, 2026
Classify SSE error events as ChatError (non-retryable, still a RuntimeError) vs TransientChatError (status 429/502/503/504 or METADATA_SYNC_IN_PROGRESS, detected before JSON parse). Wrap ChatClient.send_message and create_conversation in a bounded exponential-backoff retry (default 5 retries, 5/10/20/40/60s, ~2min cap) so a staging metadata-sync queue peak no longer fails the E2E LLM tests. Budget is overridable via GOODDATA_EVAL_CHAT_* env vars so CI can retune without cutting a new release. No new dependency. JIRA: GDAI-1929 risk: nonprod
zdenekmusil-gd
force-pushed
the
zmu/gdai-1929-genai-sse-transient-retry
branch
from
d675811 to
00331ec
Compare
hkad98
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Classify SSE error events as ChatError (non-retryable, still a RuntimeError) vs TransientChatError (status 429/502/503/504 or METADATA_SYNC_IN_PROGRESS, detected before JSON parse). Wrap ChatClient.send_message and create_conversation in a bounded exponential-backoff retry (5 retries, 5/10/20/40/60s, ~2min cap, stdlib only) so a staging metadata-sync queue peak no longer fails the E2E LLM tests. No new dependency.
JIRA: GDAI-1929
risk: nonprod