feat(sdk): support multiple MAQL candidates in metric skill evaluation#1665
Merged
Merged
Conversation
- Add `_best_maql_match` to compare actual MAQL against any candidate list - `_execute_single_metric_run` takes `expected_outputs: list[dict]` and uses `_best_maql_match`; primary candidate drives simulated user responses - `run_agentic_metric_skill` and `evaluate_agentic_metric_skill` accept `expected_output: dict | list` — single dict is wrapped automatically - Error message on failure now lists all candidates JIRA: GDAI-1831 risk: nonprod
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1665 +/- ##
=======================================
Coverage 79.21% 79.21%
=======================================
Files 232 232
Lines 15809 15809
=======================================
Hits 12523 12523
Misses 3286 3286 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
hkad98
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_best_maql_matchto compare actual MAQL against any candidate list_execute_single_metric_runtakesexpected_outputs: list[dict]and uses_best_maql_match; primary candidate drives simulated user responsesrun_agentic_metric_skillandevaluate_agentic_metric_skillacceptexpected_output: dict | list— single dict is wrapped automaticallyJIRA: GDAI-1831
risk: nonprod