feat: add IAM role credentials for artifact storage - #1475
Open
longhuynh852-work wants to merge 9 commits into
Open
feat: add IAM role credentials for artifact storage#1475longhuynh852-work wants to merge 9 commits into
longhuynh852-work wants to merge 9 commits into
Conversation
revert README changes
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (58.06%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1475 +/- ##
==========================================
+ Coverage 58.00% 58.06% +0.06%
==========================================
Files 663 663
Lines 25760 25767 +7
==========================================
+ Hits 14941 14962 +21
+ Misses 10106 10092 -14
Partials 713 713
🚀 New features to boost your workflow:
|
longhuynh852-work
changed the title
…onghuynh852-work/server into feat/iam_role_artifact_storage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desc: Vela introduced artifact storage feature to upload artifacts to S3 bucket via MinIo. We are looking to add capability to opt from using the static credentials to access the S3 bucket, rather used short-lived credentials via IAM Role.
Changes:
-added flag for UseIAM to enable IAM role credentials in storage.go and flags.go
-added if statement to use IAM role as credentials if UseIAM flag enabled in minio.go (to avoid any changes to current flow)
-avoid validation error if access/secret key not provided when UseIAM flag enabled in opts.go
-added test cases for both