Skip to content

Avoid CodeQL false positive in manifest path validation #54097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
+13 −1
Closed

Avoid CodeQL false positive in manifest path validation #54097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07e5df9
Initial plan
Copilot Aug 20, 2026
ab30530
Avoid CodeQL redirect false positive in path guard
Copilot Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/cli/add_package_manifest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,7 @@ func parseManifestIncludeMapping(mapping map[string]any, manifestPath string) (r
// paths that escape their root.
func cleanManifestRelativePath(p string) (string, error) {
slashed := filepath.ToSlash(p)
if strings.HasPrefix(slashed, "/") || strings.HasPrefix(slashed, "\\") || filepath.IsAbs(p) || isWindowsDriveRelativePath(slashed) {
if len(slashed) > 0 && (slashed[0] == '/' || slashed[0] == '\\') || filepath.IsAbs(p) || isWindowsDriveRelativePath(slashed) {
return "", errors.New("absolute paths are not allowed")
}
cleaned := path.Clean(slashed)
Expand Down
12 changes: 12 additions & 0 deletions pkg/cli/add_package_manifest_mapping_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,18 @@ import (
"github.com/stretchr/testify/require"
)

func TestCleanManifestRelativePathRejectsAbsoluteForms(t *testing.T) {
t.Parallel()

for _, input := range []string{"/tmp/reviewer.md", `\tmp\reviewer.md`, `C:/tmp/reviewer.md`} {
t.Run(input, func(t *testing.T) {
t.Parallel()
_, err := cleanManifestRelativePath(input)
assert.EqualError(t, err, "absolute paths are not allowed")
})
}
}

// setupMappingPackageTest wires the package resolution hooks so that only the manifest and
// README of a package are available, and auto-scan is disabled.
func setupMappingPackageTest(t *testing.T, manifest map[string]string) {
Expand Down