Refactor safe-output repo target accessors by Copilot · Pull Request #53838 · github/gh-aw

Copilot · 2026-08-18T22:02:46Z

Safe-output schema generation repeated AllowedRepos and TargetRepoSlug extraction across a large tool-name switch, making new tool support easy to implement inconsistently.

Registry-based targeting
- Replaced the switch with a tool-name-to-accessor registry.
- Centralized repo-parameter eligibility and description generation.
```
accessor := repoTargetAccessors[toolName]
targetConfig := accessor(safeOutputs)
```
Coverage guard
- Added a focused test that verifies the registry contains exactly the supported repo-target tools.

Fixes [duplicate-code] Refactor repeated repo-target extraction in safe output tool schema generation #53836

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 33.2 AIC · ⌖ 9.48 AIC · ⊞ 6.9K · ◷
_{Comment /souschef to run again}

Generated by PR Sous Chef run https://github.com/github/gh-aw/actions/runs/32249206937> Generated by 👨‍🍳 PR Sous Chef · gpt54 · 23.7 AIC · ⌖ 8.26 AIC · ⊞ 9.3K · ◷

_{Comment /souschef to run again}

pr-sous-chef run https://github.com/github/gh-aw/actions/runs/32358285599> Generated by 👨‍🍳 PR Sous Chef · gpt54 · 5.47 AIC · ⌖ 8.32 AIC · ⊞ 9.3K · ◷

_{Comment /souschef to run again}

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 27.5 AIC · ⌖ 8.07 AIC · ⊞ 6.9K · ◷
_{Comment /souschef to run again}

Run: https://github.com/github/gh-aw/actions/runs/32385519055> Generated by 👨‍🍳 PR Sous Chef · gpt54 · 15.1 AIC · ⌖ 8.25 AIC · ⊞ 9.3K · ◷

_{Comment /souschef to run again}

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

github-actions · 2026-08-19T00:32:50Z

PR Triage

Category: refactor · Risk: medium
Score: 44/100 (impact 22, urgency 10, quality 12)
Recommended action: batch_review
Batch: B1-safeoutput-refactor (with Extract shared safe-output target parsing #53841, Refactor agent-session safe-output parsing to a single shared path #53840)

Registry-based refactor with a coverage guard test. Part of the safe-output parsing refactor cluster — batch review recommended.

Generated by 🔧 PR Triage Agent · auto · 58.5 AIC · ⌖ 2.15 AIC · ⊞ 8.3K · ◷

github-actions · 2026-08-19T06:27:02Z

Triage: category=refactor · risk=medium · score=38/100 (impact 18/50, urgency 10/30, quality 10/20)
Recommended action: batch_review

Part of the B1-safeoutput-refactor batch (with #53841, #53840). Draft, no CI yet, no reviews. Undraft once ready and review together with the batch.

Generated by 🔧 PR Triage Agent · auto · 58.8 AIC · ⌖ 2.56 AIC · ⊞ 8.3K · ◷

Copilot

Pull request overview

Refactors safe-output repository targeting into a registry, reducing duplicated tool dispatch logic.

Changes:

Adds tool-specific repository-target accessors.
Preserves centralized repo parameter generation.
Adds registry coverage validation.

Show a summary per file

File	Description
`pkg/workflow/safe_outputs_tools_repo_params.go`	Replaces the switch with an accessor registry.
`pkg/workflow/safe_outputs_tools_generation_test.go`	Verifies the registry’s supported tool set.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Files reviewed: 2/2 changed files
Comments generated: 0
Review effort level: Balanced

github-actions · 2026-08-19T09:58:37Z

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

github-actions · 2026-08-19T09:58:45Z

✅ Test Quality Sentinel completed test quality analysis.

🧪 Test quality analysis by Test Quality Sentinel

github-actions · 2026-08-19T09:59:00Z

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

github-actions · 2026-08-19T09:59:11Z

✅ Design Decision Gate 🏗️ completed the design decision gate check.

🏗️ ADR gate enforced by Design Decision Gate 🏗️

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

…-target-extraction # Conflicts: # pkg/intent/governance_formal_test.go Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-08-20T09:49:31Z

@copilot Please take another maintainer-facing pass on this PR. Confirm the latest head is still merge-ready, refresh the branch if helpful, clear any remaining blockers, and run the pr-finisher ski...

Refreshed the branch with current main in 2502e9e; it is clean and has no unresolved review threads. make fmt, make lint, make test-unit, make recompile, and make agent-report-progress pass; secret scan and automated code review are clean. make test is blocked by pre-existing pkg/cli completion tests (write |1: file already closed) from the refreshed base. CI on this agent head is unverified and needs a maintainer-triggered run before merge.

gh-aw-bot · 2026-08-20T10:25:10Z

@copilot Please take another pass on this PR: refresh the branch if GitHub offers it, review any current CI status, and use the pr-finisher skill to move this toward merge readiness.

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 5.47 AIC · ⌖ 8.32 AIC · ⊞ 9.3K · ◷
_{Comment /souschef to run again}

Copilot · 2026-08-20T10:32:25Z

@copilot Please take another pass on this PR: refresh the branch if GitHub offers it, review any current CI status, and use the pr-finisher skill to move this toward merge readiness.

Generated by [...

2502e9e is current with main, so no refresh was needed. All review threads remain resolved, and make agent-report-progress passes. Current CI includes an in-progress Copilot run (setup, build, and workflow recompilation have passed so far); prior action-required runs contain no failed jobs or logs. GitHub still reports the PR as blocked pending required checks/review.

gh-aw-bot · 2026-08-20T11:22:22Z

@copilot Please take another maintainer-facing pass on this PR.

Refresh the branch if GitHub offers it.
Re-check current required checks and merge readiness on the latest head.
If anything is still blocking merge, address the remaining blocker directly.
Run the pr-finisher skill before handing back.

Generated by PR Sous Chef: https://github.com/github/gh-aw/actions/runs/32362964689

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 13.8 AIC · ⌖ 8.15 AIC · ⊞ 6.9K · ◷
_{Comment /souschef to run again}

Copilot · 2026-08-20T11:33:59Z

@copilot Please take another maintainer-facing pass on this PR.

Refresh the branch if GitHub offers it....

Finish pass complete at 2502e9e; it already contains current main, and all review threads are resolved. Local validation passes: make fmt, make lint, make test-unit, make test, and make recompile. The prior PR run 32358854299 succeeded; the current required Copilot check (32363492358) is still in progress, so GitHub reports the PR blocked pending that check and maintainer review. No code or refresh is actionable from this pass.

github-actions · 2026-08-20T12:28:39Z

PR Triage

Category: refactor · Risk: medium · Score: 40/100 · Action: batch_review
Batch: B1-safeoutput-refactor

CI passing, but prior approvals were dismissed after new commits — needs re-review.

_{Automated triage — see the triage report issue for full context.}

Generated by 🔧 PR Triage Agent · auto · 67 AIC · ⌖ 10.2 AIC · ⊞ 8.3K · ◷

gh-aw-bot · 2026-08-20T14:03:02Z

@copilot Please take a fresh maintainer-facing pass on this PR.

Refresh the branch if GitHub offers it.
Re-check current merge readiness and any CI or review blockers on the latest head.
Run the pr-finisher skill before handing back for maintainer review.

Generated by PR Sous Chef: https://github.com/github/gh-aw/actions/runs/32376962566

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 19.2 AIC · ⌖ 8.16 AIC · ⊞ 9.3K · ◷
_{Comment /souschef to run again}

Copilot · 2026-08-20T14:19:04Z

@copilot Please take a fresh maintainer-facing pass on this PR.

Refresh the branch if GitHub offers it....

Fresh finish pass complete at 2502e9e. The branch remains current with main; review threads are resolved; and make fmt, make lint, make test-unit, make test, and make recompile pass. Prior Copilot runs succeeded. The current Copilot check (32377843594) has passed setup, build, and workflow recompilation and is still processing, so merge remains blocked only pending that check and maintainer review; no refresh or code change is actionable.

gh-aw-bot · 2026-08-20T15:30:06Z

@copilot Please take another maintainer-facing pass on this PR.

Refresh the branch if GitHub offers it.
Confirm the resolved review feedback remains satisfied on the latest head.
Run the pr-finisher skill before handing back for maintainer review.

Generated by PR Sous Chef: https://github.com/github/gh-aw/actions/runs/32385519055

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 15.1 AIC · ⌖ 8.25 AIC · ⊞ 9.3K · ◷
_{Comment /souschef to run again}

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-08-20T15:41:51Z

@copilot Please take another maintainer-facing pass on this PR.

Refresh the branch if GitHub offers it....

Finish pass complete. aace5b5 refreshed the branch with current main; the resolved metadata-driven accessor feedback remains satisfied and all review threads stay resolved. I also removed an accidental unrelated skill-list addition, leaving no net change from that refresh. Local final validation completed (BASE_REF=HEAD~1 make agent-report-progress); prior Copilot run logs show successful completion, while the latest run on the refreshed head is still processing. Current head CI must be re-triggered or completed by a maintainer before merge.

pelikhan · 2026-08-20T16:42:37Z

@copilot fix https://github.com/github/gh-aw/actions/runs/32387662241/job/96488211106

gh-aw-bot · 2026-08-20T16:43:32Z

@copilot Please take a maintainer-facing finish pass on this PR.

Please address these failing checks on the current head:

lint-go: https://github.com/github/gh-aw/actions/runs/32387662241/job/96488211106

Please refresh the branch if GitHub offers it, verify merge readiness on the latest head, and use the pr-finisher skill before handing back.

Generated by PR Sous Chef: https://github.com/github/gh-aw/actions/runs/32392865801

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 8.42 AIC · ⌖ 10.5 AIC · ⊞ 9.3K · ◷
_{Comment /souschef to run again}

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-08-20T16:56:18Z

@copilot fix https://github.com/github/gh-aw/actions/runs/32387662241/job/96488211106

Fixed in 699abbc. The reflected AllowedRepos value now uses a checked []string assertion, satisfying the custom linter and returning the existing no-target fallback instead of panicking. BASE_REF=HEAD~1 make agent-report-progress passes.

Copilot · 2026-08-20T17:09:13Z

@copilot Please take a maintainer-facing finish pass on this PR.

Please address these failing checks on the current head:...

699abbc already fixes the reported pre-fix lint-go failure; targeted custom-linter and workflow tests pass. The current head contains the latest base and all review threads are resolved. Finish-pass local validation passed through make lint and make test-unit; make test only reproduces the pre-existing CLI completion failures (write |1: file already closed). The current Windows CI failure is an unrelated required-cache miss. Current-head CI must be rerun by a maintainer.

Initial plan

ac17ab8

Copilot AI assigned Copilot and pelikhan Aug 18, 2026

Copilot started work on behalf of pelikhan August 18, 2026 22:03 View session

Copilot AI linked an issue Aug 18, 2026 that may be closed by this pull request

[duplicate-code] Refactor repeated repo-target extraction in safe output tool schema generation #53836

Open

7 tasks

Copilot AI and others added 2 commits August 18, 2026 22:11

Refactor safe output repo target accessors

d21bb00

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Strengthen repo target registry coverage

773023e

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Refactor repeated repo-target extraction in safe output tool schema generation~~ Refactor safe-output repo target accessors Aug 18, 2026

Copilot finished work on behalf of pelikhan August 18, 2026 22:14

Copilot AI requested a review from pelikhan August 18, 2026 22:14

github-actions Bot added pr-action:batch_review pr-agent:copilot pr-batch:B1-safeoutput-refactor pr-priority:medium pr-risk:medium pr-type:refactor labels Aug 19, 2026

github-actions Bot mentioned this pull request Aug 19, 2026

Extract shared safe-output target parsing #53841

Closed

This was referenced Aug 19, 2026

Refactor agent-session safe-output parsing to a single shared path #53840

Closed

[PR Triage Report] PR Triage Report — Run 32201019113 #53866

Closed

github-actions Bot mentioned this pull request Aug 19, 2026

[PR Triage Report] PR Triage Report — 2026-08-19 (Run 32222826555) #53924

Closed

pelikhan marked this pull request as ready for review August 19, 2026 09:48

Copilot AI balanced review requested due to automatic review settings August 19, 2026 09:48

Copilot started reviewing on behalf of pelikhan August 19, 2026 09:50 View session

Copilot AI reviewed Aug 19, 2026

View reviewed changes

Copilot started work on behalf of gh-aw-bot August 20, 2026 09:25 View session

Copilot AI and others added 2 commits August 20, 2026 09:30

chore: begin maintainer finish pass

4c4f39a

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Merge remote-tracking branch 'origin/main' into copilot/refactor-repo…

2502e9e

…-target-extraction # Conflicts: # pkg/intent/governance_formal_test.go Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot August 20, 2026 09:49

Copilot started work on behalf of gh-aw-bot August 20, 2026 10:25 View session

Copilot finished work on behalf of gh-aw-bot August 20, 2026 10:32

Copilot started work on behalf of gh-aw-bot August 20, 2026 11:22 View session

Copilot finished work on behalf of gh-aw-bot August 20, 2026 11:34

github-actions Bot mentioned this pull request Aug 20, 2026

[PR Triage Report] PR Triage Report — 2026-08-20 (15 PRs) #54225

Open

Merge branch 'main' into copilot/refactor-repo-target-extraction

aace5b5

Copilot AI and others added 2 commits August 20, 2026 15:40

Verify latest PR readiness

67cd33d

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Revert unrelated skill-list change

aa9257f

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot started work on behalf of gh-aw-bot August 20, 2026 16:11 View session

Copilot finished work on behalf of gh-aw-bot August 20, 2026 16:28

pelikhan and others added 2 commits August 20, 2026 09:46

Merge branch 'main' into copilot/refactor-repo-target-extraction

619c237

Guard reflected repo target assertion

699abbc

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Uh oh!

Conversation

Copilot AI commented Aug 18, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 19, 2026

PR Triage

Uh oh!

github-actions Bot commented Aug 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

github-actions Bot commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI commented Aug 20, 2026

Uh oh!

gh-aw-bot commented Aug 20, 2026

Uh oh!

Copilot AI commented Aug 20, 2026

Uh oh!

gh-aw-bot commented Aug 20, 2026

Uh oh!

Copilot AI commented Aug 20, 2026

Uh oh!

github-actions Bot commented Aug 20, 2026

PR Triage

Uh oh!

gh-aw-bot commented Aug 20, 2026

Uh oh!

Copilot AI commented Aug 20, 2026

Uh oh!

gh-aw-bot commented Aug 20, 2026

Uh oh!

Copilot AI commented Aug 20, 2026

Uh oh!

pelikhan commented Aug 20, 2026

Uh oh!

gh-aw-bot commented Aug 20, 2026

Uh oh!

Copilot AI commented Aug 20, 2026

Uh oh!

Copilot AI commented Aug 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Aug 18, 2026 •

edited by github-actions Bot

Loading

github-actions Bot commented Aug 19, 2026 •

edited

Loading

github-actions Bot commented Aug 19, 2026 •

edited

Loading

github-actions Bot commented Aug 19, 2026 •

edited

Loading

github-actions Bot commented Aug 19, 2026 •

edited

Loading