fix(dotnet): forward CustomAgentsLocalOnly in session.create and session.resume#1899
Open
syf2211 wants to merge 1 commit into
Open
fix(dotnet): forward CustomAgentsLocalOnly in session.create and session.resume#1899syf2211 wants to merge 1 commit into
syf2211 wants to merge 1 commit into
Conversation
…ion.resume CustomAgentsLocalOnly was only sent via the post-create session.options.update call, which arrives after agent discovery has already completed. Mirror the Go SDK by including customAgentsLocalOnly in CreateSessionRequest and ResumeSessionRequest wire payloads. Fixes github#1888
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forward
CustomAgentsLocalOnlyfromSessionConfig/ResumeSessionConfiginto the .NET SDK'ssession.createandsession.resumewire payloads.Motivation
Fixes #1888. Agent discovery runs during session initialization. The .NET SDK previously only sent
customAgentsLocalOnlyvia the post-createsession.options.updatecall, which arrives too late to restrict discovery to the working directory. The Go SDK already includes this field insession.create/session.resume.Changes
customAgentsLocalOnlyto internalCreateSessionRequestandResumeSessionRequestrecordsconfig.CustomAgentsLocalOnlyinCreateSessionAsyncandResumeSessionAsyncTests
dotnet test test/GitHub.Copilot.SDK.Test.csproj --filter FullyQualifiedName~GitHub.Copilot.Test.Unit— 155 passedcustomAgentsLocalOnly— passedClientOptionsE2ETests; requiretsxin CI)Notes
session.options.updatebehavior is unchanged; this only ensures the value is present at initialization time.Fixes #1888