Forward selfFetchManagedSettings in session.create#1846
Open
joshspicer wants to merge 3 commits into
Open
Conversation
joshspicer
force-pushed
the
agents/managed-settings-forward-flag
branch
from
227887c to
9fdb1a8
Compare
Add selfFetchManagedSettings to SessionConfigBase and forward it in the session.create RPC payload. This allows hosts (e.g. VS Code AHP) to opt the runtime into enterprise managed-settings self-fetch and enforcement. Without this change, the field is silently dropped by the explicit field list in client.ts and never reaches the runtime. Requires: github/copilot-agent-runtime#agents/managed-settings-sdk-capability
joshspicer
force-pushed
the
agents/managed-settings-forward-flag
branch
from
9fdb1a8 to
ae591cc
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Threads a new opt-in session configuration flag, selfFetchManagedSettings, from the Node.js SDK configuration surface through to the runtime wire payloads for session creation and resume, enabling runtimes to self-fetch and enforce enterprise managed settings at bootstrap.
Changes:
- Added
selfFetchManagedSettings?: booleantoSessionConfigBase. - Forwarded
selfFetchManagedSettingsin thesession.createrequest payload. - Forwarded
selfFetchManagedSettingsin thesession.resumerequest payload.
Show a summary per file
| File | Description |
|---|---|
| nodejs/src/types.ts | Introduces the new selfFetchManagedSettings session config flag and documents its intended behavior. |
| nodejs/src/client.ts | Forwards the new flag through the session.create and session.resume JSON-RPC payloads. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Low
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://github.com/github/copilot-sdk-internal/issues/206
Forward
selfFetchManagedSettingsinsession.createThreads an optional
selfFetchManagedSettingsflag from the SDK config through thesession.create/resumeSessionwire calls, so consumers can opt the runtime into self-fetching enterprise managed settings at session bootstrap.nodejs/src/types.ts— addselfFetchManagedSettings?: booleantoSessionConfigBase.nodejs/src/client.ts— forward it in thesession.createandresumeSessionpayloads.Purely additive and opt-in; unset behaves exactly as before. Runtime enforcement lives in the runtime PR.
Related PRs