Skip to content

C#: NoOpPackageRestore only needs the PackageConfigs collection and n… #22011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
michaelnebel wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Draft

C#: NoOpPackageRestore only needs the PackageConfigs collection and n… #22011

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/PackagesConfigRestorer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public static IPackagesConfigRestore Create(FileProvider fileProvider, Dependenc
return new NugetExeWrapper(fileProvider, packageDirectory, logger, useDefaultFeed);
}

return new NoOpPackagesConfig(fileProvider, logger);
return new NoOpPackagesConfig(fileProvider.PackagesConfigs, logger);
}

/// <summary>
Expand Down Expand Up @@ -343,15 +343,15 @@ public void Dispose()
private class NoOpPackagesConfig : IPackagesConfigRestore
{
private readonly Semmle.Util.Logging.ILogger logger;
private readonly FileProvider fileProvider;
private readonly ICollection<string> packagesConfigs;

public NoOpPackagesConfig(FileProvider fileProvider, Semmle.Util.Logging.ILogger logger)
public NoOpPackagesConfig(ICollection<string> packagesConfigs, Semmle.Util.Logging.ILogger logger)
{
this.fileProvider = fileProvider;
this.packagesConfigs = packagesConfigs;
this.logger = logger;
}

public int PackageCount => fileProvider.PackagesConfigs.Count;
public int PackageCount => packagesConfigs.Count;

public int InstallPackages()
{
Expand Down
Loading