Fix false positives in RULE-0-0-1 from disconnected non-Stmt CFG nodes#1144
Draft
castler wants to merge 1 commit into
Draft
Fix false positives in RULE-0-0-1 from disconnected non-Stmt CFG nodes#1144castler wants to merge 1 commit into
castler wants to merge 1 commit into
Conversation
The codeql/cpp-all library (particularly version 5.0.0) can produce orphan BasicBlock nodes in the CFG that are completely disconnected (no predecessors and no successors). These nodes represent expressions, variable accesses, or function name nodes rather than actual statements. When they appear in functions with virtual calls returning complex types (like expected<void, E>), the isReachable predicate cannot reach them and they get incorrectly flagged as unreachable statements. Add isDisconnectedNonStmtBlock predicate to filter out these CFG artifacts. The predicate specifically targets blocks that: - Have no predecessors AND no successors (completely isolated) - Are not function entry points - Are not Stmt instances (the rule is about unreachable *statements*) This preserves detection of legitimate unreachable statements (e.g., code after infinite loops or noreturn calls) which are Stmt nodes with zero predecessors but may have successors. Verified: eliminates ~1182 false positives on eclipse-score/communication codebase while all existing test cases continue to pass. Fixes github#1143
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The codeql/cpp-all library (particularly version 5.0.0) can produce orphan BasicBlock nodes in the CFG that are completely disconnected (no predecessors and no successors). These nodes represent expressions, variable accesses, or function name nodes rather than actual statements. When they appear in functions with virtual calls returning complex types (like expected<void, E>), the isReachable predicate cannot reach them and they get incorrectly flagged as unreachable statements.
Add isDisconnectedNonStmtBlock predicate to filter out these CFG artifacts. The predicate specifically targets blocks that:
This preserves detection of legitimate unreachable statements (e.g., code after infinite loops or noreturn calls) which are Stmt nodes with zero predecessors but may have successors.
Verified: eliminates ~1182 false positives on eclipse-score/communication codebase while all existing test cases continue to pass.
Fixes #1143
Change request type
.ql,.qll,.qlsor unit tests)Rules with added or modified queries
Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.