update git2-hooks to 0.3.3 to use default login shell instead just bash - #4749
Merged
mtsgrd merged 1 commit intoAug 25, 2024
Merged
Conversation
|
@yerke is attempting to deploy a commit to the GitButler Team on Vercel. A member of the Team first needs to authorize it. |
mtsgrd
reviewed
Aug 24, 2024
| checksum = "da03fa3b94cc19e3ebfc88c4229c49d8f08cdbd1228870a45f0ffdf84988e14b" | ||
| dependencies = [ | ||
| "dirs 5.0.1", | ||
| "dirs 4.0.0", |
Contributor
There was a problem hiding this comment.
Hmm, this downgrade looks a bit weird? gitui depends on 5.0.
Contributor
Author
There was a problem hiding this comment.
Hmm, I am not sure why cargo decided to resolve to that version when I ran cargo update git2-hooks. shellexpand has dirs = { version = ">=4, <6", optional = true }, and dirs 4 in Cargo.lock comes from resolve-path.
Removed this change.
yerke
force-pushed
the
yerke/update-git2-hooks-version
branch
from
August 24, 2024 18:09
117331e to
5807e1d
Compare
krlvi
approved these changes
Aug 25, 2024
krlvi
left a comment
krlvi
left a comment
Member
There was a problem hiding this comment.
thanks for fixing this upstream in git2_hooks <3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
Fixes #4569
🧢 Changes
Update git2-hooks to 0.3.3. That version includes gitui-org/gitui#2343.
🎫 Affected issues
Fixes: 4569